Next.js: Standard Prettier

Created on 28 Mar 2017  路  8Comments  路  Source: vercel/next.js

An idea:

  • Next.js should prefer " over ' everywhere. ' is a relic.
  • No semicolons once Prettier will support it.
  • Add CLI task to fix code via prettier.

Most helpful comment

I'm +1 on implementing prettier + xo like all other ZEIT projects. For consistency, and there's a lot of PRs that had a failed build cause of style stuff prettier catches 馃憤

All 8 comments

We won't have built in linting tools.
Exising tools are much simpler to use.
And with out custom webpack config, you could plug it into webpack process as well.

@rauchg Whatever, but Next.js source code should be prettified I suppose.

@steida We use standard and some of the eslint rules.
And I don't think we don't need more than that.

Give Prettier a chance for a minute in your IDE :-)

I'm +1 on implementing prettier + xo like all other ZEIT projects. For consistency, and there's a lot of PRs that had a failed build cause of style stuff prettier catches 馃憤

cc @rauchg

@rauchg Prettier is awesome.

That's what I am using as npm script

"prettier": "prettier --bracket-spacing --single-quote --tab-width 2 --trailing-comma all --parser babylon --print-width 80  --write \"{{components,epics,lib,mutations,pages,reducers,scripts,test,themes,types},__{tests,mocks,generated}__}/**/*.js\"",

Maybe we should take whole current dir, and ignore node_modules and .next dirs.

@steida

"prettier": "prettier --bracket-spacing --single-quote --tab-width 2 --trailing-comma all --parser babylon --print-width 80 --write "{{components,epics,lib,mutations,pages,reducers,scripts,test,themes,types},__{tests,mocks,generated}__}/*/.js"",

Cool, but this is not compatible with styled jsx

Was this page helpful?
0 / 5 - 0 ratings