Newpipe: a few issues that are related to the same thing

[panacist]

first i would love to thank you guys for the hard work on this new version !

and look i really appreciate the convincing arguments of @opusforlife2 and the deadly comments of @avently ,but despite that i am still opposing the idea of having two seperate players while watching a video (the main player and the one in the notifications).
nonetheless here are a few issues that i've encountered probably due to that (i might be wrong) :
(initial conditions: no trending page, autoplay is off, and a smile?)

issue number 1:

1. play (in the background) any video
2. minimize the video
3. press the home button
4. go back to the app (from recent apps) and maximize the video again

issue number 2:

1. go to youtube music
2. play (in the background) any piece written by bach or preferably chopin
3. keep pressing the phone's back arrow untill you're out of the app
4. go back to the app (the minimized thing disappears)

issue number 3:

1. play bach again from youtube music
2. go to soundcloud top 50
3. try playing the second song (which is not supported by newpipe)
4. how can i go back to bach's comments ?

(another issue related to this one is that when you press the back arrow you close the stream instead of minimizing it)

issue number 4:

1. play bach again (i'm sorrry about it )
2. go to soundcloud top 50 again
3. press the first song (which is supported by newpipe)
4. why does bach stop playing while autoplay is off?

issue number 5 (not sure how to reproduce):

1. play (in the background) well chopin this time
2. enjoy the music a bit
3. go to soundcloud hot and new
4. press really quickly the first song there
5. and before the tumbnail loads click the big headset icon to play it (not in the background)
6. it will play chopin instead.

[avently]

Opusforlife2 will be here soon and will close the issue...
But thanks for a great start! I'm not sure how to translate the "deadly comments" but the post is something I wanted to read

[opusforlife2]

@avently You know the code. If all 5 issues written here are related to the same underlying problem, then we don't need to close it. If 2 of them are one problem and 3 are another problem, then we make two issues, and so on.

[panacist]

@avently i was just kidding about the deadly comments let's say not "user friendly" ones haha
@opusforlife2 sorry for putting a bunch of issues in the same place again !

[panacist]

@opusforlife2 an out of subject question : is it fine to post issues that i have no idea how to reproduce?

[avently]

1. What happens in this case? What's the issue and what mean (in the background)? I'm just tried to open a video in background player with steps provided but didn't find anything unusual
2. Initially I shut down the background player and popup player in this case but later I was asked to leave background player and popup player playing. So I did it. You see the cost. For me it's ok since you can choose any video and not lose the playback state anyway.
3. Have no idea. The unsupported things are not covered. Better to create a new issue for this one
4. If you have disabled autoplay it will not start playing a new video but will stop previous. Expected behavior
5. Before info is loaded you know only about previous track. After info loads it will be used for playing

[opusforlife2]

is it fine to post issues that i have no idea how to reproduce?

@panacist You should, because someone else may find out how to reproduce it. But make sure you give as many details as possible.

[panacist]

@avently

1. here is what happens for me :
   
   and in the background is the headset icon
2. so it isn't to be considered a bug is that what you mean ?
3. sure maybe opus can open an issue (as you may have noticed i am the worst man to describe issues).
4. not an expected behavior !! if you remember i once was having a descussion with you and opus about whether to stop the playing video when chosing to play the next one and opus was like hey you will have time to enjoy the playing video while the other is being loaded. so i just wonder is it not the case here ? giving the assumption that autoplay is off stoping the previous video without my consent is unusual
5. okay then fair enough

[opusforlife2]

@panacist After you find out which are real issues and which aren't, I expect you'll open separate bug reports for each because, as avently rightly said, I will close this.

[avently]

(2). You can open an issue if you want but I don't think this rare situation should cost hours of finding a solution which don't look ugly
(4). If I don't stop the previous video you'll get video working in the background without displaying it. It will load a video (not an audio) which is a bad situation. We didn't talk about this implementation because it has no alternatives
We talked about when to stop the video: right after choosing another or when another one has downloaded info to show. We chose the second way.

[avently]

(1) Show a screenrecord please

[panacist]

@avently

1. no need to open an issue you guys have enough already
2. sure thing, i think you and opus flipped roles you are the convincing guy now haha and opus is angry about the template
3. i will provide it as soon as possible.

[opusforlife2]

Not angry. Just firm in my stance. :3

[avently]

@opusforlife2 why are you sooooo angry? We just listening people's problems...

[opusforlife2]

no need to open an issue

@panacist Open an issue, please. Whether or not someone fixes it is not your problem.

[opusforlife2]

@avently What is the cause of (2)? Why doesn't the minimised player stay?

For (5), should we avoid showing buttons until video details have loaded?

[avently]

@opusforlife2 because when you press back and your backstack is empty, activity with all fragments gets destroyed (mini player located inside a fragment). After returning back you have a blank activity without loaded videodetailsfragment

[opusforlife2]

@avently Okay. Can there be a condition added that if the foreground service is active/playing a stream, not to close the minimised player on back press? The entire point of the minimised player was that it would let streams play uninterrupted until the user manually closed it.

[avently]

@opusforlife2 not like you said, but in a different way. Once new activity gets created the service needs to be found in running processes and in case it's found activity should send a broadcast related to the need to open and connect mini player. The broadcast i'm talking about I added in the last my PR. These are all instructions I can give you. If you know Android it's enough

[opusforlife2]

@avently Could you open a new issue with these instructions? I'll see if someone can work on it.

[avently]

@opusforlife2 no, I'm not. You may open if you want.

[opusforlife2]

@panacist I'm closing this. Please open separate issues now.