Newpipe: Deleting Files 3 times but they never get deleted...

[goxr3plus]

Maybe this is a phone problem but it was not before.

In the downloads section i press delete, all okay the song dissapears but then if i continue deleting songa, the deleted reappear again and actually they never get deleted from the memory :'(

[theScrabi]

Could you make a video of the deletion pls

[goxr3plus]

Yes. I will.

On Sat, Oct 6, 2018, 18:57 Christian Schabesberger [e-mail]
wrote:

Could you make a video of the deletion pls

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/TeamNewPipe/NewPipe/issues/1793#issuecomment-427584893,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATbiwF0D9azeQAbasBD2RGQEgyA-_F9lks5uiNMEgaJpZM4XLaD1
.

[nachoparker]

I can verify this. In order to really delete the file I have to hit back several times until I have completely exited the app.

Otherwise, the fail is not really deleted and shows up again next time you go to downloads

thanks!

[goxr3plus]

@nachoparker Exactly my friend :) , couldn't send a real pick of it , like should make a short gif.

[theScrabi]

It's the snakbar, it seems not to work, so we should get rid of it.

[theScrabi]

Help welcome :)
You can find the relevant code here:
https://github.com/TeamNewPipe/NewPipe/blob/dev/app/src/main/java/org/schabi/newpipe/download/DeleteDownloadManager.java

[TobiGr]

IIRC this has been fixed in #1759.

I used this branch for a couple of days and didn't notice the incorrect behavior any more.

Unfortunately, I am testing a different PR now, so I can't check this again atm.

[nachoparker]

I forgot to mention something else. If you delete the downloaded files externally, for instance, from VLC, this doesn't get detected by NewPipe and the files still show in the downloads section.

[theScrabi]

Yea thats because there is an internal database that holds a reference to the files. One might have to write an updater that checks if the file still exists.

[TobiGr]

fixed in #1759

[nachoparker]

thank you very much