Newpipe: [waiting for exoplayer] Switch resolution without buffering

[dkanada]

• [x] I carefully read the contribution guidelines and agree to them.
• [x] I checked if the issue/feature exists in the latest version.

It would be nice if the video player didn't switch to the new resolution until it built up a buffer. This would allow the video to continue playing rather than stop to reload the video.

[turboteckel]

Isn't this a YouTube thing?

[ildar]

Yes, smooth resolution switch is YT feature, I guess not so trivial.

[theScrabi]

Well with exoplayer we could do that. But we needed someone who knows how to handle exoplayer well.

[ildar]

The man appeared?

[theScrabi]

They come and go. But no this has not happen yet :/

[ildar]

@avently , can you give your opinion on this issue? Thanks!

[avently]

@ildar when a video from playlist ends I don't see a loading indicator. This means somehow exoplayer can preload a video. But as you know this thing doesn't work when you skip a video manually with a right arrow button. Theoretically it is possible to switch to a next video (or another resolution) without a gap but practically I couldn't find a place in code where we can tell exoplayer to start preloading from a specified playback position. Maybe someone has a time to look at the source of Exoplayer and find such a place of code where magic happens

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[opusforlife2]

@Redirion Is this possible in Exoplayer?

[Redirion]

@opusforlife2 this reminded me of an issue I saw at ExoPlayer. The issue is still open: google/ExoPlayer#3327

I think it would come to exactly that as each video resolution should have its own internal url

[opusforlife2]

Is the stream with a different resolution 'concatenated' in the same way? That issue seems to be talking more about playlists or queues.

[Redirion]

to my understanding, if NewPipe would support it, one could queue the same video in a playlist in different resolutions, as both should have distinct video stream urls.

[opusforlife2]

So how would that work for changing resolutions? The second video would be queued with a timestamp? Will that work?

[Redirion]

yes it would work this way if we had the possibility to pre buffer a second video, but this is not yet a feature of ExoPlayer. Creating it manually like described in the issue seems also a bit heavy (instantiation a second player to be able to switch to that player instance). On lower end devices or with low/unstable internet speeds this could also hurt the user experience.

[opusforlife2]

@Stypox How's the idea of a "waiting for upstream" or even "waiting for Exoplayer" label?

[Stypox]

@opusforlife2 Idk, it seems like a too-specific label, a good title would do just as well