Netty: Missing log placeholder for "-Dio.netty.allocator.useCacheForAllThreads" (io.netty.buffer.PooledByteBufAllocator)

[isdom]

netty start log SHOULD output: -Dio.netty.allocator.useCacheForAllThreads true/false

BUT now start log output: -Dio.netty.allocator.useCacheForAllThreads, missing actual value

start any netty server or client with LOG Level : DEBUG

netty-all-4.1.7.Final

JDK: java version "1.8.0_102"

OS: Linux XXX 3.10.0-327.22.2.el7.x86_64 #1 SMP Thu Jun 23 17:05:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

Now code is:

logger.debug("-Dio.netty.allocator.useCacheForAllThreads", DEFAULT_USE_CACHE_FOR_ALL_THREADS);
Would PooledByteBufAllocator LOG code be better to code like this?

logger.debug("-Dio.netty.allocator.useCacheForAllThreads: {}", DEFAULT_USE_CACHE_FOR_ALL_THREADS);

[normanmaurer]

@isdom yes... Want to open a PR to fix it ?

[jasontedor]

In Elasticsearch we use a logger checker to ensure that this never happens; we fail the build if the placeholders do not match the arguments.

[isdom]

@normanmaurer I fell asleep... next time I will try open a PR to fix simple issue.

[normanmaurer]

@isdom you can still do if you like :) We love contributions 👍

[isdom]

thanks @normanmaurer , let me try...

[normanmaurer]

Fixed by https://github.com/netty/netty/pull/6268