Netlify-cms: Bug(locales): CMS still has hard coded English strings

Created on 12 Dec 2019  路  7Comments  路  Source: netlify/netlify-cms

Related issue: https://github.com/netlify/netlify-cms/issues/2947

Screenshots from that issue:

Screen Shot 2019-12-04 at 5 05 53 PM
Screen Shot 2019-12-04 at 5 06 01 PM
Screen Shot 2019-12-04 at 3 37 01 PM
Screen Shot 2019-12-04 at 3 37 03 PM
Screen Shot 2019-12-04 at 4 54 52 PM

Please add more relevant screenshots if you identify more hard coded strings.

i18n good first issue bug

Most helpful comment

@pniedzwiedzinski your fix is already an improvement so thank you :) As each translation we have was contributed by a different persons(s), I don't think we need to wait. The process so far has been that people would close the gap from the English version when they have the time - we just need to expose a way for them to do so.

All 7 comments

widget locales

Hi, is this issue available for me to work on?

@tiuweehan, go for it. I think Login with Netlify Identity should be fixed by now, and the login modal might require fixing in https://github.com/netlify/netlify-identity-widget.

As I mentioned in #3186
image

As I mentioned in #3186
image

I already made this simple fix for that https://github.com/pniedzwiedzinski/netlify-cms/tree/optional-hardcoded, but I added only English and Polish translations.

Should we add all translations at once? And should we merge all these small fixes in one PR?

@pniedzwiedzinski your fix is already an improvement so thank you :) As each translation we have was contributed by a different persons(s), I don't think we need to wait. The process so far has been that people would close the gap from the English version when they have the time - we just need to expose a way for them to do so.

Closing as I believe this is fixed

Was this page helpful?
0 / 5 - 0 ratings