Netlify-cms: Docs site navigation broken on mobile

[anjackson]

The main navigation menu on the NetlifyCMS docs site appears to be broken on iOS Safari. Once I go to https://www.netlifycms.org/docs/intro I can’t navigate to the other pages.

[tech4him1]

I can confirm this on BrowserStack iPhone X on iOS 11.

JS console errors:

TypeError: undefined is not an object (evaluating 't.props.history.push')

Using a link instead of a menu is broken as well:

The "push" method is now deprecated and will be removed in Gatsby v3. Please use "navigate" instead.
A page wasn't found for "/start-with-a-template/"
A page wasn't found for "/404.html"

[tech4him1]

This is a regression from https://github.com/netlify/netlify-cms/pull/1623, and is broken in all browsers.

[tech4him1]

@zebapy Mind checking into this?

this.props.history is not defined here:
https://github.com/netlify/netlify-cms/blob/f801b192211b1e1953ced969a3093eab9e04e14d/website/src/components/mobile-nav.js#L5

[zebapy]

I will today hopefully

[zebapy]

I thought a simple swap to @reach/router's navigate corrected this (https://github.com/zebapy/netlify-cms/commit/250c242ccc15cd597df8b2c257d1dea5a8ba5a6d) but now I have some other gatsby problem https://github.com/gatsbyjs/gatsby/issues/7643

[tech4him1]

@zebapy Is it worth just fixing them in seperate PRs? I think we could go ahead and merge the navigate one now. The 404 bug seems to be affecting other links on the page as well, so we can do a seperate PR once that is resolved. Thank you so much for looking into this!

[raniesantos]

Possibly related:

The js on the https://www.netlifycms.org/docs/widgets/ page seems to be broken. The buttons at the bottom of the page don't show the widgets.

[zebapy]

@raniesantos I cannot reproduce this on chrome 68. @tech4him1 did you?

Also what other links have 404 issues?

[zebapy]

I mocked up (in code) the nav if it was a toggle and normal links (so it works again). Any interest in this? https://github.com/zebapy/netlify-cms/compare/gatsby-v2...zebapy:website-mobile-nav

[tech4him1]

@zebapy I'd be fine with that. It's probably more accessible anyway, since it's a real nav.

[tech4him1]

@raniesantos I cannot reproduce, can you give me browser details?

[raniesantos]

I fixed it. A (global) userscript that I installed with Tampermonkey was causing it.

[erquhart]

Do it 👍