Netbox: Comments field missing label on bulk edit

Created on 28 Jan 2020  路  4Comments  路  Source: netbox-community/netbox

Environment

  • Python version: 3.6.8
  • NetBox version: 2.7.2

Steps to Reproduce

  1. Navigate to racks list /dcim/racks/
  2. Select a rack and then click the Edit selected button

This affects bulk edit forms for Rack, Cluster, Virtual Machine, and Provider.

Expected Behavior

The comments field on the right has a label

Observed Behavior

A mysterious field appears to have no label
image

accepted bug

All 4 comments

Just needs a quick git apply of:

diff --git a/netbox/circuits/forms.py b/netbox/circuits/forms.py
index d5d78e7..b2ccde9 100644
--- a/netbox/circuits/forms.py
+++ b/netbox/circuits/forms.py
@@ -89,7 +89,8 @@ class ProviderBulkEditForm(BootstrapMixin, AddRemoveTagsForm, CustomFieldBulkEdi
         label='Admin contact'
     )
     comments = CommentField(
-        widget=SmallTextarea()
+        widget=SmallTextarea(),
+        label='Comments'
     )

     class Meta:
diff --git a/netbox/dcim/forms.py b/netbox/dcim/forms.py
index e713d2c..cb301a4 100644
--- a/netbox/dcim/forms.py
+++ b/netbox/dcim/forms.py
@@ -676,7 +676,8 @@ class RackBulkEditForm(BootstrapMixin, AddRemoveTagsForm, CustomFieldBulkEditFor
         widget=StaticSelect2()
     )
     comments = CommentField(
-        widget=SmallTextarea
+        widget=SmallTextarea,
+        label='Comments'
     )

     class Meta:
diff --git a/netbox/virtualization/forms.py b/netbox/virtualization/forms.py
index ae516fc..ed1e5e2 100644
--- a/netbox/virtualization/forms.py
+++ b/netbox/virtualization/forms.py
@@ -171,7 +171,8 @@ class ClusterBulkEditForm(BootstrapMixin, AddRemoveTagsForm, CustomFieldBulkEdit
         )
     )
     comments = CommentField(
-        widget=SmallTextarea()
+        widget=SmallTextarea(),
+        label='Comments'
     )

     class Meta:
@@ -535,7 +536,8 @@ class VirtualMachineBulkEditForm(BootstrapMixin, AddRemoveTagsForm, CustomFieldB
         label='Disk (GB)'
     )
     comments = CommentField(
-        widget=SmallTextarea()
+        widget=SmallTextarea(),
+        label='Comments'
     )

     class Meta:

Related to #3575

And also to #713

We'll get it one day. :laughing:

Was this page helpful?
0 / 5 - 0 ratings

Related issues

billyzoellers picture billyzoellers  路  3Comments

luto picture luto  路  3Comments

mrfroggg picture mrfroggg  路  3Comments

Grokzen picture Grokzen  路  3Comments

benjy44 picture benjy44  路  3Comments