Netbox: Bulk edit of pass-through ports not saving when ports 1 and 2 selected

[kwoodVisions]

Environment

• Python version: 3.5.2
• NetBox version: 2.5.6

Bulk-editing of pass-through ports does not save if ports 1 and 2 are selected in the range of ports to edit. If all ports are selected except 1 and 2, changes do save. This occurs with Front and Rear ports.

Steps to Reproduce

1. Navigate in the system to one of our patch panels.
2. Scroll down to either Front Ports or Rear Ports.
3. Click check box next to "Name" to select all ports.
4. Scroll down and click "Edit" underneath the section selected.
5. On the bulk edit page, change any setting - doesn't matter which.
6. Click Apply.
7. Browser does not navigate away from the page. What you had attempted to change does not in fact change.
8. Go back to the patch panel page, scroll down to the Front Ports or Rear Ports section and click the check box next to "Name".
9. Uncheck ports 1 and 2.
10. Scroll down and click "Edit".
11. Edit anything - description, type, etc.
12. Click Apply - your changes have now been saved.

** This also works if you just randomly select any port in the list, so long as you do not select port 1 or 2.

The expect behavior is that when clicking Apply, the changes I entered would be applied.

Changes were not saved. The same bulk edit page was displayed again without any changes.

[jeremystretch]

I'm not able to reproduce this. This part:

1. Browser does not navigate away from the page

suggests to me that it's a browser issue. The "Apply" button is just a regular <button type="submit"> element; there's no Javascript involved.

I see that you've already got a thread going on the mailing list, so I'm going to close this out for now and continue the discussion there. If we find a way to reproduce the behavior, I'll reopen this issue.

[jeremystretch]

Per Brian Candler on the mailing list:

OK, I can reproduce this now!

• pick any device
• add rearports using pattern [1-96]. Defaults for all other fields.
• back at the device, select all rearports (using the checkbox which selects all)
• select Edit
• select type 100 Punch
• click Apply

The page just refreshes.

[kwoodVisions]

Per Brian Candler on the mailing list:

OK, I can reproduce this now!

• pick any device
• add rearports using pattern [1-96]. Defaults for all other fields.
• back at the device, select all rearports (using the checkbox which selects all)
• select Edit
• select type 100 Punch
• click Apply

The page just refreshes.

Yes!! That's it!!

[jeremystretch]

Boy that's a weird one. Nice work! Found the issue:

class RearPortBulkEditForm(BootstrapMixin, AddRemoveTagsForm, BulkEditForm):
    pk = forms.ModelMultipleChoiceField(
        queryset=Interface.objects.all(),
        widget=forms.MultipleHiddenInput()
    )

The form is checking the specified primary keys against Interfaces instead of RearPorts.

[kwoodVisions]

Sneaky little bugger - I'm glad you found it in the code so quickly!

[jeremystretch]

Fixed this and also added an error dump at the top of the page to hopefully make troubleshooting future bugs easier. Thanks again!