Nest: Possibility of ClientsModule.registerAsync

[feihan]

Feature Request

Is your feature request related to a problem? Please describe.

Currently i have to write static values into ClientModule.register().
I would like to inject my ConfigModule and read values from there.

Describe the solution you'd like

Make a ClientsModule.registerAsync(). Like the TypeormModule / HttpModule / ...

Teachability, Documentation, Adoption, Migration Strategy

The registerAsync is a very common pattern in nestjs.

What is the motivation / use case for changing the behavior?

Make values configurable thorugh other Modules or services. No need for static typed values.

That would help me a lot.
Thank you for your awesome product!

[jmcdo29]

Is anyone working on this? I can give it a shot if not

[kamilmysliwiec]

@jmcdo29 PR would be more than welcome :)

[feihan]

@jmcdo29 would be great. If you need help, let me know.

[jmcdo29]

What would be the main difference in creating a ClientsModule.registerAsync() vs using a Custom Provider that uses a factory as shown in the docs?

[kamilmysliwiec]

@jmcdo29 I'm guessing it's just all about the consistency with other @nestjs/ modules. Using a custom provider approach would work fine in this case as well :)

[jmcdo29]

To anyone who would like to take a crack at this, it'll be a while before I can get back to it, so feel free 😸

[Hexenon]

Im going to work on this one, because i need this feature. Hope i do it right.

[Yonatanb4]

Any update?

[Amorites]

Hi @Hexenon , how's it going now? Help needed?

[Hexenon]

Hi @Hexenon , how's it going now? Help needed?

i have lot of work i started it and researching how to achieve it, wanna join ?

[Amorites]

i have lot of work i started it and researching how to achieve it, wanna join ?

Sounds great! Is there any task that can be split？

[Hexenon]

i have lot of work i started it and researching how to achieve it, wanna join ?

Sounds great! Is there any task that can be split？

first of all, research how ClientsModule factory works, and understand how providers can be returned asynchronously within NestJS provider factory and what other methods are in there to dynamically return providers or modules

[Amorites]

i have lot of work i started it and researching how to achieve it, wanna join ?

Sounds great! Is there any task that can be split？

first of all, research how ClientsModule factory works, and understand how providers can be returned asynchronously within NestJS provider factory and what other methods are in there to dynamically return providers or modules

I made a Pull Request according to your prompt. Would you please give a review?

[Hexenon]

i have lot of work i started it and researching how to achieve it, wanna join ?

Sounds great! Is there any task that can be split？

first of all, research how ClientsModule factory works, and understand how providers can be returned asynchronously within NestJS provider factory and what other methods are in there to dynamically return providers or modules

I made a Pull Request according to your prompt. Would you please give a review?

good job, all makes sense to me. Its exactly what I was in my wip fork. now let's wait until they review and merge.