Nest: Update to Axios 0.19.1, it's released & fixes a major bug, custom config (details inside)

Created on 7 Jan 2020 · 5Comments · Source: nestjs/nest

Bug Report

Current behavior

Passing in custom config (so they can be picked up in the interceptor) was broken in axios 0.19.0, its been a long time coming but its finally released! 0.19.1!

I send a previous report asking to be downgraded but it wasn't possible. https://github.com/nestjs/nest/issues/3665

Now we have an official release.

The major problem about the config was this PR

https://github.com/axios/axios/pull/2207

This has now been released (with other fixes also) here

https://github.com/axios/axios/releases

Any chance of upgrading as this is a real blocker as our interceptors can't pick up any custom properties that you send down, they get erased :-(

To reiterate, it was broken in 0.19.0 and 0.19.1 fixes this and other things.

Thanks

done 👏 deps

Source

iangregsondev

👍4

Most helpful comment

There is already a PR for this from the renovate bot: #3765. Hopefully there will be a patch with it soon

jmcdo29 on 7 Jan 2020

👍5

All 5 comments

There is already a PR for this from the renovate bot: #3765. Hopefully there will be a patch with it soon

jmcdo29 on 7 Jan 2020

👍5

Great - thanks !

iangregsondev on 8 Jan 2020

Fixed in 6.11.0

kamilmysliwiec on 24 Jan 2020

👍1

Thanks @kamilmysliwiec I noticed it included the 0.19.2 - which is good news as they introduced a bug with regards to XSS and having the word javascript in urls.

This was fixed in 0.19.2

Thanks!

iangregsondev on 24 Jan 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.