Nest: Upgrade to v6 - overrideGuard not work in tests
Hi!
I'm submitting a bug
[ ] Regression
[X] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.
const module = await Test.createTestingModule({
imports: [...],
})
.overrideGuard(AuthGuard)
.useValue({ canActivate: () => true })
.compile();
const app = module.createNestApplication();
Current behavior
Does not override guard.
Expected behavior
On version 5.* it works as expected. So the guard is overrided.
Environment
Nest version: 6.1.1 (also for testing module)
For Tooling issues:
- Node version: 8.15
- Platform: Linux
aistrati
All 19 comments
Please, provide a minimal repository which reproduces your issue.
kamilmysliwiec
on 24 Apr 2019
Hi Kamil!
Added a repo here - https://github.com/aistrati/nestjs6-update
aistrati
on 24 Apr 2019
Thanks, I'll look at it shortly
kamilmysliwiec
on 25 Apr 2019
@kamilmysliwiec Hi!
Do you have any updates on this ?
Or maybe I can contribute on this somehow ?
aistrati
on 7 May 2019
Hi @kamilmysliwiec, the issue was introduced by 5922e7ed9c88c29e25dad4d5ae77e0347a426231 in version 6.1.1.
vitalik123
on 15 May 2019
Fixed in 6.2.1 :) Thanks for reporting
kamilmysliwiec
on 19 May 2019
I think i'm having this issue again, 6.2.4
Bnaya
on 29 May 2019
Confirming. On latest version it's still not working...
aistrati
on 29 May 2019
Just pulled the repo again and everything works fine. Please, create a separate issue if you face any issue (+attach repo which reproduces your problem)
kamilmysliwiec
on 29 May 2019
A workaround, instead of overrideGuard:
const guard = moduleFixture.get(AuthGuardWithAllowSentry);
guard.canActivate = () => Promise.resolve(true);
https://github.com/aistrati/nestjs6-update is not alive anymore.
Bnaya
on 30 May 2019
@Bnaya repo is alive (it's set as private). If you face any issue, please, create a separate issue with the included repo.
kamilmysliwiec
on 30 May 2019
@Bnaya I made it public.
@kamilmysliwiec It's not reproducibile on the repo. We will update the repo when guard is not overriden (under some circumstances need to figure out).
aistrati
on 30 May 2019
@kamilmysliwiec Hi! Updated the repo which reproduce the error. Seems like it's working on controller level, but not on method. Take a look, please.
aistrati
on 30 May 2019
@kamilmysliwiec I have the same issue, this problem appeared after adding enhancers and if
you have several Guards or another similar enhancers in your controller (for example several methods wrapped by the same Guard). Then new InstanceWrapper will be created for each described Guard. Their metadata store as array: https://github.com/nestjs/nest/blob/4624a241999f237adf5fc4a46f0ccc698cb89e94/packages/core/injector/instance-wrapper.ts#L159
But at the same time this enhancer add as an injectable to module (injectables stored as Map) And so new instance of InstanceWrapper will override previous: https://github.com/nestjs/nest/blob/4624a241999f237adf5fc4a46f0ccc698cb89e94/packages/core/injector/module.ts#L147
And thats why when you try to override in test this kind of enhancer in fact you override only the last Guard in this controller: https://github.com/nestjs/nest/blob/4624a241999f237adf5fc4a46f0ccc698cb89e94/packages/core/injector/module.ts#L349
Goodluckhf
on 4 Jun 2019
@kamilmysliwiec @aistrati @Bnaya
UPD: there is already bug fix in master. https://github.com/nestjs/nest/commit/aed28959b88cb7b350d474c86237efd739dd0928
We are waiting for new release :)
Goodluckhf
on 4 Jun 2019
Fixed in the latest release :)
kamilmysliwiec
on 5 Jun 2019
Fixed in the latest release :)
if the module has multiple Controllers then you're unable to override AuthGuard()
waqasshargeel
on 28 Sep 2019
Fixed in the latest release :)
if the module has multiple Controllers then you're unable to override AuthGuard()
Same issue !
jogelin
on 4 Oct 2019
Please, if you face any issue, provide a minimal repository and create a separate issue.
kamilmysliwiec
on 4 Oct 2019
Related issues
hackboy
路
3Comments
JulianBiermann
路
3Comments
rlesniak
路
3Comments
cojack
路
3Comments
menme95
路
3Comments
Most helpful comment
Fixed in the latest release :)