Nest: WebSocket adapters

[ProbablePrime]

It would be great to extract the websocket functionality to use a proper adapter pattern.

Right now there's a stub of an adapter which just returns a socket.io instance.

Ideally:

• Wrap any websocket functionality in an adapter
• Call that in nest side code

This lets socket.io be potentially swapped out for alternatives, without breaking changes.

[hustcer]

uWebSockets should be better than socket.io, IMO

[d3viant0ne]

Socket.io is familiar to most of the Angular community of which Nest has it's roots. I don't disagree that uWebSockets outperforms socket.io at scale but imo Nest shouldn't make choices like that for consumers.

As @ProbablePrime said above, make it pluggable, support what makes sense & allow consumers to make their own tooling choices.

[kamilmysliwiec]

Hi @ProbablePrime,
Since latest update you should be able to use custom socket.io adapter. Example:

import { SocketIoAdapter } from '@nestjs/common';

class CustomAdapter implements SocketIoAdapter {
    create(port: number) {
        return {};
    }
    createWithNamespace(port: number, namespace: string) {
        return {};
    }
}

const app = NestFactory.create(ApplicationModule, instance);
app.setIoAdapter(new CustomAdapter());

[ProbablePrime]

@kamilmysliwiec I don't think this addresses the issue.

The issue is asking for a way to replace Socket.io completely. Right now this appears to just require an adapter to return Socket.io instances. It would still require the whole Socket.io interface on the object returned from createWithNamespace

[cojack]

@kamilmysliwiec will be this #80 pr merged in a few days?

[kamilmysliwiec]

@cojack, yes :smiley:

[ProbablePrime]

This looks a lot better \o/ thanks! doing a more indepth read of your changes but i will close it most likely

[kamilmysliwiec]

Hi @ProbablePrime,

Since 3.0.0 you can create adapter for any ws library. Read more

[ProbablePrime]

Yep PERFECT. thanks!

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.