Nes.css: Bug: Borders is not responsive anymore

Created on 4 Jan 2019  路  11Comments  路  Source: nostalgic-css/NES.css

Describe the bug
The borders has a few bugs in some resolutions. It's hard to explain but is easy to show, see Screenshots below:

To Reproduce

  1. Go to the develop branch;
  2. Change the line 17 of the index.html file to <link href="./css/nes.min.css" rel="stylesheet" />;
  3. Run npm run build;
  4. You can use something like php -S localhost:4167;
  5. Check localhost:4167;
  6. Zoom in and out and see that this bug happens.

Expected behavior
Nothing happened with the borders by changing the resolution/zoom.

Screenshots
image

image

image

image

image

image

Environment:

  • OS: Ubuntu 16.04 / Ubuntu 18.10 (test it on both)
  • Browser: Google Chrome Version 71.0.3578.98 64 bits
  • Build environment (i.e. NodeJS): v10.15.0

Suggestion(s) for fixing this issue
I've no ideia how to fix it. Only solution I see is reverting the borders back for now before the next release.

Additional context
In master this is not happening.

bug released

All 11 comments

Maybe this is related to #72 .
What is set for -webkit-font-smoothing: antialiased;? 馃

I fixed border bugs #261
Did you reproduce the bug yet? 馃

This is happening only when I zoom in and out in develop:

Example when I zoom in (150%)

image

Example when I zoom out (75%)

image

Chrome: Version 72.0.3626.81 64 bits

Note: This isn't happening in Firefox.

Thanks 馃檱
It's reproduce when zooming in Chrome. I got it 馃憤
I'll check and fix again 馃敡

When I set space to image-border-repeat, it was a little better. 馃
But it is not perfect. 馃槶

Chrome 72 / zoom 150%

2019-02-05 20 37 34
2019-02-05 20 37 43

This is way better now than it was before. It is not breaking the layout or anything like that.

Yes, it's not perfect but good enough for me, because I'm not even sure if this could be better.
If you want to make a PR with this I'm ok with that :+1:

I see 馃槅
I'll make a PR. 馃殌

:tada: This issue has been resolved in version 2.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

I'm still having this issue on your demo website, the borders don't scale well to zooming in Chrome (I'm on Ubuntu 18.04)

Example at 150%:
screenshot from 2019-03-04 16-54-56

Yes, I'm sorry about this @deepPhong.
The idea is to fix this issue again in #319.
Ref #317.
If you want I can reopen this.

Oh no I'm fine, I didn't see it was already planned for a fix and just wanted you guys to know. Cheers and keep up the good work

Was this page helpful?
0 / 5 - 0 ratings

Related issues

panoramix360 picture panoramix360  路  6Comments

BcRikko picture BcRikko  路  6Comments

YuK1Game picture YuK1Game  路  6Comments

alexd99 picture alexd99  路  3Comments

BcRikko picture BcRikko  路  6Comments