Nes.css: Bug: White border of the container is-dark is missing

Created on 3 Jan 2019  路  3Comments  路  Source: nostalgic-css/NES.css

Describe the bug
The container with-title class is not working anymore.

To Reproduce
Check out the containers in index.html master and develop or run storybook.

Expected behavior
The is-dark class in intended to have a border white _inside_ the container.

image

Screenshots
image

Environment:

  • OS: Ubuntu 18.04
  • Browser: Chrome 71.0
  • Build environment (i.e. NodeJS): Node v9.11.1

Suggestion(s) for fixing this issue
image

As you can see in the picture above, I changed manually to border-color: red, so the default white border is outside of the container, unlike it was before.

Additional context
Not sure what happened here.

bug released

Most helpful comment

This is happening when the screen width exceeds 979px, if you scale the viewport width down below 980px again, you'll see the border return. I'm not 100% sure what this means, but I'll continue to investigate.

All 3 comments

This is happening when the screen width exceeds 979px, if you scale the viewport width down below 980px again, you'll see the border return. I'm not 100% sure what this means, but I'll continue to investigate.

I think it's somehow losing the ::before and ::after psuedo-class styling at the 980px breakpoint? I'm not seeing the behavior on the page I'm building that references the framework from the CDN, only on the Storybook version. Could this be an issue due to something it's inheriting from Storybook's built-in styles?

:tada: This issue has been resolved in version 2.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

Was this page helpful?
0 / 5 - 0 ratings

Related issues

BcRikko picture BcRikko  路  6Comments

evexoio picture evexoio  路  5Comments

megane42 picture megane42  路  3Comments

HiKaylum picture HiKaylum  路  4Comments

StefanNieuwenhuis picture StefanNieuwenhuis  路  3Comments