Nes.css: Storybook container .is-dark font color same as background color

Created on 7 Dec 2018  路  3Comments  路  Source: nostalgic-css/NES.css

storybook-isdark

This issue happens in storybook only.

bug released

All 3 comments

maybe...
https://github.com/nostalgic-css/NES.css/blob/ac136794133f8e5cb70b09993e40ff8561b2bda0/scss/elements/containers.scss#L103-L118

  &.is-dark {
+    color: $background-color;
    &::before { ... }
    &::after { ... }
    &.with-title { ... }
  }

and

https://github.com/nostalgic-css/NES.css/blob/ac136794133f8e5cb70b09993e40ff8561b2bda0/index.html#L60-L63

        <div class="container is-dark with-title">
          <p class="title">Container.is-dark</p>
-          <p style="color: white;">Good morning. Thou hast had a good night's sleep, I hope.</p>
+          <p>Good morning. Thou hast had a good night's sleep, I hope.</p>
        </div>
        <div class="container is-rounded">
          <p>Good morning. Thou hast had a good night's sleep, I hope.</p>
        </div>
        <div class="container is-rounded is-dark">
-          <p style="color: white;">Good morning. Thou hast had a good night's sleep, I hope.</p>
+          <p>Good morning. Thou hast had a good night's sleep, I hope.</p>
        </div>

@BcRikko yep, that fixes it 馃憤

:tada: This issue has been resolved in version 1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

Was this page helpful?
0 / 5 - 0 ratings

Related issues

evexoio picture evexoio  路  5Comments

kefniark picture kefniark  路  5Comments

alexd99 picture alexd99  路  3Comments

trezy picture trezy  路  6Comments

maartenterpstra picture maartenterpstra  路  4Comments