Nes.css: Suggestion: remove font import

Created on 29 Nov 2018 · 9Comments · Source: nostalgic-css/NES.css

It would be nice if it was the responsibility of the consumer of the library to import the required Google Font.

I would suggest leaving out the import, and updating the documentation to reflect the fact that the user should install the font themselves.

released

Source

montezume

👍2

Most helpful comment

@IngwiePhoenix sure, but then you remove the ability to load fonts async for users that want to do that. And for users that are already loading other Google fonts on their site, they will have to make two requests instead of one.

I think the unintended confusion could be mitigated with decent documentation. Something like:

Usage

This framework depends on the google font Press Start 2P. You can include it on your website like below.

<head>
    <link href="https://fonts.googleapis.com/css?family=Press+Start+2P" rel="stylesheet">
    <link href="path/to/Nes.css" rel="stylesheet">
</head>

montezume on 29 Nov 2018

👍8

All 9 comments

I was thinking the same thing as you, because I'm a Japanese font user, so Press Start 2P is not enough👍

BcRikko on 29 Nov 2018

AFAIK Google even offers CDN imports for fonts.

Personally, I am against removing the import. For people who just want to use this for a fun little site, that may just have learned HTML for instance, this could lead to some unintended confusion. But, that’s just my two cents on this.

IngwiePhoenix on 29 Nov 2018

I think the unintended confusion could be mitigated with decent documentation. Something like:

Usage

This framework depends on the google font Press Start 2P. You can include it on your website like below.

<head>
    <link href="https://fonts.googleapis.com/css?family=Press+Start+2P" rel="stylesheet">
    <link href="path/to/Nes.css" rel="stylesheet">
</head>

montezume on 29 Nov 2018

👍8

@IngwiePhoenix sure, but then you remove the ability to load fonts async for users that want to do that. And for users that are already loading other Google fonts on their site, they will have to make two requests instead of one.

I think the unintended confusion could be mitigated with decent documentation. Something like:

Usage

This framework depends on the google font Press Start 2P. You can include it on your website like below.
<head>
    <link href="https://fonts.googleapis.com/css?family=Press+Start+2P" rel="stylesheet">
    <link href="path/to/Nes.css" rel="stylesheet">
</head>

I agree, this makes the documentation more informative and declarative while loosely coupling the distribution of the font from the framework. :+1: