Neovim-qt: Problem with uppercase accented characters

[einars]

It seems to be currently impossible to type uppercase (latvian) characters like Ā, Ē, Š — special characters that require shift to be pressed. Everything works just fine in nvim in a terminal (urxvt, arch linux).

To reproduce, you may switch to a latvian keyboard layout (setxkbmap lv) and type altgr-S (observe lower-case š) and altgr-shift-S (observe nothing, Š expected).

InputConv.convertKey builds a

I worked around the issue by patching input.cpp to prevent any out-of-ASCII-range ( > 127) keys to have shift modifier ever sent, if nvim doesn't seem to support it:

      // Remove SHIFT
-     if (c.unicode() < 0x100 && !c.isLetterOrNumber() && c.isPrint()) {
-         mod &= ~ShiftModifier;
-     }
+     if (c.unicode() >= 0x80) {
+         mod &= ~ShiftModifier;
+     }
      ...

and it seems to be working, but I'm not sure what new cans of worms does it open.

[einars]

My original suggestion is buggy and is having issues with some ASCII symbols (shift-' to get a quote stopped working). This one's better:

      // Remove SHIFT
-     if (c.unicode() < 0x100 && !c.isLetterOrNumber() && c.isPrint()) {
+     if (c.unicode() >= 0x80 || (!c.isLetterOrNumber() && c.isPrint())) {

[clason]

This also happens on a German keyboard with capital umlauts (ÜÖÄ), which don't require any modifier keys (apart from shift, of course). Your patch fixes this for me as well.

[koalefant]

It is not impossible to type uppercase cyrillic letters on X11 and Windows.

Mentioned above change seems to fix the situation.

[MarcelHB]

Does that referenced commit fix this issue? This is showbreaking for writing Docs/TeXs in German. I greatly appreciate a bugfix release for this.

[diefans]

at least for me ÜÄÖ are working now...
I was just patching according to the comment of @einars, so I have no idea if that is breakin something else..