neon build fails with node.js 10

Created on 2 May 2018  路  4Comments  路  Source: neon-bindings/neon

See nodejs/nan#766.

Most helpful comment

A PR has been opened with my changes

All 4 comments

Alright, it appears that

https://github.com/neon-bindings/neon/blob/4e2273c14de6820d81cb377a44e5634b88f69174/crates/neon-runtime/src/neon.cc#L30-L32

this function fails to build due to

../src/neon.cc:32:16: error: no member named 'Callee' in 'v8::FunctionCallbackInfo<v8::Value>'
  *out = info->Callee();

So it looks like it's been removed from V8? I'll keep investigating, but once this builds I'm guessing it will work.

It does appear that it was marked as deprecated:

https://codereview.chromium.org/1582793004/patch/1/10001

But has since been removed:

https://chromium-review.googlesource.com/c/v8/v8/+/741600

I'll look at the possibility of moving to ->Data()

A PR has been opened with my changes

Was this page helpful?
0 / 5 - 0 ratings