Neomake: Flow error format issue

Created on 23 Jun 2016  路  6Comments  路  Source: neomake/neomake

Currently, the flow maker gives out a relatively uninformative error message.

image

It only gives out the line number, column, and the first line of the error message. I believe this is because the argument '--one-line' was removed in #265. However, adding that argument isn't ideal either, since the message gets extremely long.

image

For comparison, running flow by itself on a command line gives
image

The plugin vim-flow solves this by actually having multiple lines for an error.
image

Is there any way that we can do this in neomake?

maker

Most helpful comment

As mentioned, I built a json output formatter, which turned out to be very useful.
I made it public and added directions on how to set everything up with neomake

https://github.com/ryyppy/flow-vim-quickfix

All 6 comments

Right now, I am currently writing a utility which takes the flow --json output and formats it to a more neomake friendly message (but WIP)... so far it looks promising, hopefully I can integrate it as a custom maker for the beginning to see how it fits... As soon as I get this thing as I want it (in my daily practise), I will let you know!

vim-flow uses the following errorformat (in https://github.com/flowtype/vim-flow/blob/master/plugin/flow.vim#L36):

'%EFile "%f"\, line %l\, characters %c-%.%#,%Z%m,'

As mentioned, I built a json output formatter, which turned out to be very useful.
I made it public and added directions on how to set everything up with neomake

https://github.com/ryyppy/flow-vim-quickfix

@ryyppy This can now probably be added relatively easily to neomake itself with the new json parse function. See this pull request for an example: https://github.com/neomake/neomake/pull/942

There have been some fixes since this was reported: 92d782b9, bd16a861, and d5582067.
So how much is this an issue still?

Apart from that it might be good to provide steps for actually reproducing this - IIRC you need a config etc.

As for errors on multiple lines, and other ideas see https://github.com/neomake/neomake/issues/832.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

sassanh picture sassanh  路  6Comments

stjepang picture stjepang  路  4Comments

msecret picture msecret  路  4Comments

iwyg picture iwyg  路  6Comments

blueyed picture blueyed  路  6Comments