Neofetch: Disk label is yellow by default

[christanaka]

Description

By default, the label for info disk is yellow:

print_info() {
    ...
    info memory
    info disk
    ...
}

Neofetch version

3.0 on OSX 10.12.3

Screenshot

Verbose log

https://gist.github.com/anonymous/c2ef68eafb09e48c8aa3719844e7faa9

[konimex]

I'm curious, is this your expected output (since you deleted the subtitle)?

2294MB / 16384MB
58G / 279G

[dylanaraps]

I've fixed the issue. #641

I won't merge this until @konimex's question is answered so we can figure out the expected output. The PR currently prints it like the comment above.

[christanaka]

I agree with @konimex. Totally missed the label added to the output.

[dylanaraps]

Will merge the fix now :+1:

[christanaka]

@dylanaraps Not too sure what you would do in the case of multiple disks though...

[dylanaraps]

We can append the disk name to the end of the string:

58G / 279G (21%) [/]
58G / 279G (21%) [/mnt/Local Disk]

[christanaka]

Actually, I'd prefer it at the beginning hierarchy-wise. Thoughts?

[dylanaraps]

Like this?

Also which brackets (if any)?

[/] 58G / 279G (21%)
[/mnt/Local Disk] 58G / 279G (21%) 

(/) 58G / 279G (21%)
(/mnt/Local Disk) 58G / 279G (21%) 

/: 58G / 279G (21%)
/mnt/Local Disk: 58G / 279G (21%) 

[christanaka]

Yes. As far as formatting goes I would remove the brackets. Just like how the OS X diskutil list command does:

/dev/disk0 (internal):
   #:                       TYPE NAME                    SIZE       IDENTIFIER
   0:      GUID_partition_scheme                         500.3 GB   disk0
   1:                        EFI EFI                     314.6 MB   disk0s1
   2:          Apple_CoreStorage Macintosh HD            300.3 GB   disk0s2
   3:                 Apple_Boot Recovery HD             650.0 MB   disk0s3
   4:       Microsoft Basic Data BOOTCAMP                199.0 GB   disk0s4

/dev/disk1 (internal, virtual):
   #:                       TYPE NAME                    SIZE       IDENTIFIER
   0:                            Macintosh HD           +300.0 GB   disk1

[dylanaraps]

Just to confirm, you'd prefer this?:

/: 58G / 279G (21%)
/mnt/Local Disk: 58G / 279G (21%) 

[dylanaraps]

Also what color would you expect the output to be?

This is what it currently looks like:

[christanaka]

Yes, but that's just my opinion. It's think it's arbitrary and can be changed later if needed/wanted.

I would expect the color to be the color of the title if it's considered as part of the title:

Disk /: 58G / 279G (21%)
Disk /mnt/Local Disk: 58G / 279G (21%) 

Otherwise I'd expect it to be the same color of the value:

Disk:
    /: 58G / 279G (21%)
    /mnt/Local Disk: 58G / 279G (21%) 

[dylanaraps]

Done!

Thanks for your input. :)