Neofetch: Neofetch 3.0 shell command broken with /bin/zsh shell

[iraquitan]

Description

The neofetch output seems to be broken on the shell command. I'm using Neofetch 3.0 installed through homebrew and using the same config file as in master. My current shell script is as folows:

$ echo $SHELL
/bin/zsh

Neofetch version

Neofetch 3.0

Screenshot

The cropped output:

if I comment the shell command on config, the output is not cropped:

Verbose log

The verbose log is found here: http://pastebin.com/sifHL6EJ

Config file

And the config file used here: http://pastebin.com/K2YF33jv

[dylanaraps]

Thanks for opening this. :)

• Does the issue still occur with neofetch --shell_version off?
• What's the output of this command?: zsh --version

[iraquitan]

With neofetch --shell_version off the issue is gone.

*note: I'm now at work in a different machine, but I had the same issue as in my personal machine.

[dylanaraps]

What's the output of zsh --version? This is the only command that gets run in the shell function, which makes it the only possible cause of the issue.

[iraquitan]

zsh 5.3.1 (x86_64-apple-darwin15.6.0)

[dylanaraps]

Weird.

What about this?

• "$SHELL" --version

Also what version of bash do you have installed?

• bash --version

[iraquitan]

I have homebrew zsh installed but not used. Thats why zsh --version is different

$ "$SHELL" --version
zsh 5.0.8 (x86_64-apple-darwin15.0)

$ bash --version
GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin15)
Copyright (C) 2007 Free Software Foundation, Inc.

[dylanaraps]

The shell function might include something incompatible with bash 3 and that's why it's suddenly exiting. I'll install bash 3 and see if I can reproduce this.

[dylanaraps]

I can reproduce this with bash 3, working on a fix now. :+1:

[dylanaraps]

This was the offending line: shell="${shell/ ${SHELL##*/}}", I'm not sure why this caused bash to crash. The issue should be fixed now, try out the latest master and let me know if it still occurs. :)

Edit: Here's the error from bash 3:

bash3: bad substitution: no closing `}' in  ${SHELL##*

Edit2: More digging, this is (probably) a parser bug in bash 3!

Source: http://stackoverflow.com/a/32481879

Edit3: This was also an issue in bash 4.2 and was fixed sometime after.

Source: http://unix.stackexchange.com/questions/137506/how-to-combine-bashs-process-substitution-with-here-document

[dylanaraps]

Closing this, reopen it if you're still experiencing the issue. :)