Neofetch: Split neofetch into multiple files

Created on 4 Apr 2016  路  14Comments  路  Source: dylanaraps/neofetch

neofetch is huge with almost 3000 lines of code. It should be split into multiple files.

We can also add a script that combines all the little scripts into a single one, making possible distributing _neo_fetch in a single file.

Enhancement

Most helpful comment

giphy

All 14 comments

giphy

*3000

I _really_ don't want to do this but I'll start work on it anyway.

Why not?

See #219

I really want to know why should we split this into many files. As @tudurom mentioned in #219 the speed is exactly the same. screenfetch has ~4000 lines in their code. IMO there's just no technical advantage to split it up.

If we split neofetch in multiple files, it would be easier to contribute on it.

It's still very easy to contribute to neofetch as the script is split up into folds which act as a break between functions/blocks. See these screenshots showing how every function is split into its own block. You may need to open the images in a new tab to see the text.

2016-04-11-020256_1020x898_scrot
2016-04-11-020307_1020x898_scrot

iirc this kind of folds are for vim only

The folds should work in any text editor that supports code folding, what text editor are you using?

https://en.wikipedia.org/wiki/Code_folding#Software_with_code_folding_capability

i use neovim. neovim has a known issue for taking long to open long files.

I'm also using neovim and have no issues opening the file, hm.

Let's set a cap for when to split neofetch. Let's say if it exceeds 5000 lines, we split it.

Nope.

I don't want to split the script up into multiple files and I don't see the benefit in doing
so.

I'm closing this issue now, if anybody can implement this with some clear benefits I'll
think about merging it.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ghost picture ghost  路  5Comments

SolitudeSF picture SolitudeSF  路  4Comments

tadly picture tadly  路  9Comments

zoenglinghou picture zoenglinghou  路  6Comments

aranega picture aranega  路  7Comments