Neo: Make fee format be unified.

[superboyiii]

In getblocksysfee, fee returns full decimals. However, in getrawtransaction, fee has decimal point. I think it's necessary to make fee format be unified in RPC, otherwise, it'll make a lot of users be comfused.

[erikzhang]

Can you find all APIs that return inconsistent formats?

[erikzhang]

And which one do you prefer to return? Long or decimal?

[shargon]

I prefer as decimal

[superboyiii]

Can you find all APIs that return inconsistent formats?

Sure.

[superboyiii]

@erikzhang
getnep5balances--->amount(full decimals)
getnep5transfers--->amount(full decimals)
getunclaimedgas--->result(full decimals)
getapplicationlog--->value(full decimals)
getbalance--->balance(full decimals)
getblock--->net_fee,sys_fee(decimal point)
getrawtransaction--->net_fee,sys_fee(decimal point)
invokefunction, invokescript--->gas_consumed, value(full decimals)
sendfrom, sendtoaddress, sendmany--->net_fee,sys_fee(decimal point)
getblocksysfee --->result(full decimals)
cli command line: decimal point
If we choose full decimals, I think we‘d better add subscript to help read value.

[erikzhang]

I prefer to return long in RPC, and return decimal in command line.

Because in RPC, the results are for programs, and long is easy for programs to process. In command line, the results are for human reading.

What do you think?

[igormcoelho]

Because in RPC, the results are for programs, and long is easy for programs to process. In command line, the results are for human reading.

Couldn't agree more Erik. long is good for me too on RPC.

[shargon]

have sense, is good for me

[erikzhang]

getapplicationlog--->value(full decimals)

invokefunction, invokescript--->gas_consumed, value(full decimals)

What value? I didn't see it.

[erikzhang]

@superboyiii Please check the fixes.

[superboyiii]

@erikzhang OK

[superboyiii]

getapplicationlog--->value(full decimals)

invokefunction, invokescript--->gas_consumed, value(full decimals)

What value? I didn't see it.

I mean the invocation return value. Such like this:

[erikzhang]

These are StackItems and I don't think they have any problems.