Neo: Send the peers before close a connection if MaxConnections is reached. ('Endpoint isn't able to be connected if all seed nodes' peer number up to MAX(40 for now)')
I've met a situation that all seed nodes have the connected number of 40 which is the max. Then I start a clear node to connect to mainnet, however, endpoint isn't able to be connected since there's no free endpoint anymore. Although finally, after two minutes, the node find a free endpont to connect and the block grows successfully, I think this issue may cause besiege-source-attack since it's very easy to achieve. Now we have to make a solution to handle more nodes. The external nodes' number is truely growing up more and more and we mustn't reject them.
@shargon @vncoelho @igormcoelho @erikzhang
superboyiii
All 10 comments
We can change the settings of MaxConnections in config.json.
erikzhang
on 9 Aug 2019
100 instead of 40?
shargon
on 9 Aug 2019
But we should implement an ACL for ban or disconnect bad nodes, acording the response time, the expected messages, etc
shargon
on 9 Aug 2019
We can change the settings of
MaxConnectionsin config.json.
I know this operation, but its not a final solution since it will push more and more pressure on seed nodes and seed nodes need to upgrade its hardware or bandwidth more often in the future. Maybe we should make a more smart solution, for example, when a seed node is full on connection, make it still be able to recommand its peers to new nodes which would like to join for connection. If its peers are all full too, they could recommend their peers to it and so on, like a tree structure.
superboyiii
on 9 Aug 2019
I like your idea @superboyiii
shargon
on 9 Aug 2019
For me is ready-to-implement:
- Send the peers before close a connection because
MaxConnectionswas raised.
shargon
on 11 Aug 2019
@shargon let's give the team at least 2 days to review it. If someone else approves I think we are good to go
lock9
on 11 Aug 2019
Good insight, @superboyiii!
Sounds an informative and good decision.
When implementing it let's consider the design of a flexible message of information.
In the future nodes could even share statistics between what they think about their peers.
vncoelho
on 11 Aug 2019
@vncoelho That's great!
superboyiii
on 12 Aug 2019
fixed in #1154, plz review it
Tommo-L
on 11 Oct 2019
Related issues
igormcoelho
路
53Comments
ZhangTao1596
路
43Comments
brianlenz
路
37Comments
erikzhang
路
72Comments
lock9
路
62Comments
Most helpful comment
I know this operation, but its not a final solution since it will push more and more pressure on seed nodes and seed nodes need to upgrade its hardware or bandwidth more often in the future. Maybe we should make a more smart solution, for example, when a seed node is full on connection, make it still be able to recommand its peers to new nodes which would like to join for connection. If its peers are all full too, they could recommend their peers to it and so on, like a tree structure.