Neo: Extend VersionPayload with service information
Currently if one wants to discover available network services like RPC or REST you need to know about http://monitor.cityofzion.io/, https://happynodes.f27.ventures/ or something alike.
A solution to discover such services via the network would be to extend the VersionPayload with RPCPort, RESTPort and Websocket port (the most common ones currently missing). Then turn the Services into a flag that indicates which services are enabled.
https://github.com/neo-project/neo/blob/5222283c9f718217d550ca789a32c383d17749d3/neo/Network/P2P/Payloads/VersionPayload.cs#L10
This allows one to connect to the network and discover available services via the nodes (through a combination of PeerInfo requests and VersionPayload's). The aforementioned websites could also discover more available services improving the overall user experience.
ixje
All 9 comments
The VersionPayload.Services field is basically designed for this purpose.
erikzhang
on 15 Jan 2019
That's what I expected, but we miss the port information elsewhere
ixje
on 15 Jan 2019
Once we add the Services flags, we can extend the VersionPayload structure.
erikzhang
on 15 Jan 2019
is this planned for 3.0 or perhaps sooner?
ixje
on 15 Jan 2019
Example:
c#
void ISerializable.Deserialize(BinaryReader reader)
{
Version = reader.ReadUInt32();
Services = (ServicesFlags)reader.ReadUInt64();
Timestamp = reader.ReadUInt32();
Port = reader.ReadUInt16();
Nonce = reader.ReadUInt32();
UserAgent = reader.ReadVarString(1024);
StartHeight = reader.ReadUInt32();
Relay = reader.ReadBoolean();
if (Services.HasFlag(ServicesFlags.Websocket))
{
WebsocketPort = reader.ReadUInt16();
}
...
}
erikzhang
on 15 Jan 2019
Looks good
ixje
on 15 Jan 2019
We should add protocol version, and the possibility to negotiate other protocols, in the future we should consider to use UDP for receive messages.
shargon
on 15 Jan 2019
Done with the Capabilities
shargon
on 22 May 2019
Done with the Capabilities
@shargon @lock9 please reopen as capabilities do not seem to be intended for the purpose of sharing RPC or REST services according to https://github.com/neo-project/neo/issues/1342#issuecomment-563196531
ixje
on 9 Dec 2019
Related issues
erikzhang
路
4Comments
canesin
路
3Comments
lock9
路
4Comments
igormcoelho
路
3Comments
csmuller
路
3Comments
Most helpful comment
Example:
c# void ISerializable.Deserialize(BinaryReader reader) { Version = reader.ReadUInt32(); Services = (ServicesFlags)reader.ReadUInt64(); Timestamp = reader.ReadUInt32(); Port = reader.ReadUInt16(); Nonce = reader.ReadUInt32(); UserAgent = reader.ReadVarString(1024); StartHeight = reader.ReadUInt32(); Relay = reader.ReadBoolean(); if (Services.HasFlag(ServicesFlags.Websocket)) { WebsocketPort = reader.ReadUInt16(); } ... }