Nebular: errors after update Angular to 11.0.0

Created on 13 Nov 2020  路  8Comments  路  Source: akveo/nebular

Issue type

  • [x] bug report
  • [ ] feature request

Issue description

Current behavior:
errors after update Angular to 11.0.0

image

Expected behavior:
without errors

Steps to reproduce:

  • update angular deps to 11.0.0

StackBlitz: https://stackblitz.com/edit/nebular-angular11

Other information:

npm, node, OS, Browser
```
Node = v14.15.0, npm = 6.14.8
OS: Windows 10
Browser: Chrome

Most helpful comment

I am curious if anyone is working on this. what would it take to upgrade to angular 11? is there a plan to update soon? I think in the process this would get fixed. Anyone already working on this?

All 8 comments

I can confirm to have the same issue

Happens to me too.

for constructor of ViewportRuler in angular 11 the document is require :

    constructor(_platform: Platform, ngZone: NgZone, 
    /** @breaking-change 11.0.0 make document required */
    document?: any);

error is for super() method that needs document parameter:

export class NbViewportRulerAdapter extends ViewportRuler {
  constructor(platform: NbPlatform, ngZone: NgZone,
              protected ruler: NbLayoutRulerService,
              protected scroll: NbLayoutScrollService) {
    super(platform, ngZone);
  }

please change this:

super(platform, ngZone, document);

2572

I am curious if anyone is working on this. what would it take to upgrade to angular 11? is there a plan to update soon? I think in the process this would get fixed. Anyone already working on this?

Temporary fix using patch-package https://github.com/akveo/nebular/issues/2572#issuecomment-731615605

This problem has been fixed in this version: (but steel in Beta)

https://www.npmjs.com/package/@nebular/theme/v/7.0.0-beta.1

so far works as expected! thanks a lot!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

dragonbane0 picture dragonbane0  路  3Comments

maihannijat picture maihannijat  路  3Comments

andredatsch picture andredatsch  路  3Comments

suku-h picture suku-h  路  3Comments

VictorSchleumer picture VictorSchleumer  路  4Comments