Nativescript: support #rrggbbaa instead of #aarrggbb

Created on 10 Apr 2020  路  2Comments  路  Source: NativeScript/NativeScript

in the web the standard is #rrggbbaa but {N} supports #aarrggbb
Right now i am facing an issue with webpack which is wrongly translated colors in production
https://github.com/NativeScript/nativescript-dev-webpack/issues/1133

It also have bad side effects like in VSCode which wrongly shows those colors.

Now i know it is a breaking change for user. So what i am thinking about is a flag in the app package.json to use the new format.

Would you agree with that? (i could make a simple PR)

breaking-change enhancement in progress ns-next
Source
picture farfromrefug

Most helpful comment

@NathanaelA here is the PR https://github.com/NativeScript/NativeScript/pull/8519

picture farfromrefug on 11 Apr 2020
🎉2

All 2 comments

@farfromrefug - Make a PR for this. No need for a flag -- I think it would best to match the web as much as possible. We should be able to put this into NS 7 as NS 7 will have other breaking changes... Make sure all the tests are updated; as their are a lot of tests with color in them, not sure how many deal with alpha. :-)

NathanaelA picture NathanaelA on 10 Apr 2020
👍1

@NathanaelA here is the PR https://github.com/NativeScript/NativeScript/pull/8519

farfromrefug picture farfromrefug on 11 Apr 2020
🎉2
Was this page helpful?
0 / 5 - 0 ratings

Related issues

NickIliev picture NickIliev  路  3Comments
dhanalakshmitawwa picture dhanalakshmitawwa  路  3Comments
NordlingDev picture NordlingDev  路  3Comments
dxshindeo picture dxshindeo  路  3Comments
guillaume-roy picture guillaume-roy  路  3Comments