Nativescript: iOS 13: New modal view style doesnt clean up when swiped to close

Created on 19 Sep 2019 · 5Comments · Source: NativeScript/NativeScript

All latest, xcode 11 and official iOS 13:

When you swipe to close a modal (new native control), frame.topmost().currentPage.modal is not cleared out.

One side effect is this:
Open a modal, swipe to dismiss it, then try to open a dialog.

This line in dialogs fails:

var currentView = dialogs_common_1.getCurrentPage() || application_1.getRootView();
    if (currentView) {
        currentView = currentView.modal || currentView;

currentView becomes currentView.modal, which is gone, so the dialog is not presented.

backlog bug ios

Source

davecoffin

👍3

Most helpful comment

HI @davecoffin,
I was able to recreate the problem with nativescript-sdk-examples-js. I will mark the issue as a bug and we will investigate it further.

tsonevn on 20 Sep 2019

👍2

All 5 comments

If anybody finds this and needs a quick workaround:
setting fullscreen to true on the modal presents the old style, which is not draggable, so doing that fixes the problem, you just lose the nice draggable modal.

davecoffin on 19 Sep 2019

HI @davecoffin,
I was able to recreate the problem with nativescript-sdk-examples-js. I will mark the issue as a bug and we will investigate it further.

tsonevn on 20 Sep 2019

👍2

@ADjenkov
Does #8024 actually fix this? Or just provide an API to not let the user close the modal with a gesture?

davecoffin on 20 Nov 2019

@davecoffin yes it fixes the problem you've reported and also provides new API to enable/disable it