Nativescript: TabView.iosIconRenderingMode property

[leocaseiro]

After accepting the #2435 and merging the c3ce128e6578271e31e03131f469cd78bd1186ea into core, the tab icons color have become always blue and we have to harcoded to fix it back.

While we are not able to choose the icon tab color, I suggest we make optional to choose the render between UIImageRenderingModeAutomatic and UIImageRenderingModeAlwaysOriginal.

I'm happy to send a PR with something like:

<TabView rendering="automatic"> or <TabView rendering="alwaysoriginal">

Other References Issues: #260 #1278

[DomGaud]

Update: With new version should be able to switch
from _automatic_
( var originalRenderedImage = is.ios.imageWithRenderingMode(0); )

to _alwaysoriginal_
( var originalRenderedImage = is.ios.imageWithRenderingMode(1); )

[hamorphis]

@leocaseiro @DomGaud So basically, if I add a new iOS-specific public property to the TabView class which allows setting the rendering mode everyone will be happy. Is that correct?

[hamorphis]

    /**
     * Gets or set the UIImageRenderingMode of the tab icons in iOS. 
     * Valid values are:
     *  - automatic
     *  - alwaysOriginal
     *  - alwaysTemplate  
     */
    iosIconRenderingMode: string;

If undefined, it will use UIImageRenderingMode.Automatic.

[hamorphis]

<TabView iosIconRenderingMode="alwaysOriginal">...</TabView>

[leocaseiro]

Hi @hamorphis, that's exactly the kind of solution I was expecting for. Perfect!

Thank you so much for that.

[DomGaud]

Perfect! Thanks @hamorphis

[hamorphis]

@leocaseiro @DomGaud The pull request is merged into the master branch. It will be released with 2.5.0. since we are already in a code-freeze for 2.4.0

[leocaseiro]

Thank you so much for that @hamorphis.

I really appreciate it!

[DomGaud]

@hamorphis Thank you.

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.