Nativescript-plugin-firebase: Types conflicts with tns-core-modules

Created on 23 Mar 2017  路  3Comments  路  Source: EddyVerbruggen/nativescript-plugin-firebase

Hi,

Recent changes added "fs-promise" as dependency which add @types/node (added by @types/fs-extra) as a dependency and causing types conflict with tns-core-modules:

node_modules/@types/node/index.d.ts(38,11): error TS2300: Duplicate identifier 'MapConstructor'.
node_modules/@types/node/index.d.ts(40,11): error TS2300: Duplicate identifier 'SetConstructor'.
node_modules/tns-core-modules/es-collections.d.ts(30,14): error TS2300: Duplicate identifier 'MapConstructor'.
node_modules/tns-core-modules/es-collections.d.ts(31,14): error TS2300: Duplicate identifier 'SetConstructor'.
picture SBD580

Most helpful comment

seems like fs-promise fault as not adding the Types dependencies to devDependencies. I opened a PR.
As a workaround just npm uninstall @types/fs-extra @types/mz @types/node after installing/updating the plugin.

picture SBD580 on 23 Mar 2017
👍2 ❤1

All 3 comments

seems like fs-promise fault as not adding the Types dependencies to devDependencies. I opened a PR.
As a workaround just npm uninstall @types/fs-extra @types/mz @types/node after installing/updating the plugin.

SBD580 picture SBD580 on 23 Mar 2017
👍2 ❤1

You're the best @SBD580! An update (2.0.1) to fs-promise has already been published and since this plugin just takes the latest 2.x version this problem should not occur anymore for folks installing this plugin.

EddyVerbruggen picture EddyVerbruggen on 23 Mar 2017

I'm glad I could help :)
Thank you for this entire plugin!

SBD580 picture SBD580 on 23 Mar 2017
Was this page helpful?
0 / 5 - 0 ratings

Related issues

thunder413 picture thunder413  路  3Comments
phatakrajan picture phatakrajan  路  4Comments
tsili852 picture tsili852  路  3Comments
vchimev picture vchimev  路  3Comments
romandragan picture romandragan  路  3Comments