Nativebase: Excess bottom space in the ActionSheet

[venkatmithun]

I have gone through these following points

• [x] Check latest documentation: https://docs.nativebase.io/
• [x] Check for existing open/closed issues for a possible duplicate before creating a new issue: https://github.com/GeekyAnts/NativeBase/issues
• [x] Use the latest NativeBase release: https://github.com/GeekyAnts/NativeBase/releases
• [x] Check examples from NativeBase KitchenSink https://github.com/GeekyAnts/NativeBase-KitchenSink
• [x] For discussion purpose make use of NativeBase Slack: http://slack.nativebase.io/
• [x] For queries related to theme, check Theme Variables from Docs and live NativeBase Theme Editor http://nativebase.io/customizer/

Issue Description

node, npm, react-native, react and native-base version, expo version if used, xcode version

node: 10.0.0
npm: 5.6.0
react-native: 0.58.5
react: 16.6.3
native-base: 2.12.0

Expected behaviour

No extra space after last item

Actual behaviour

Extra space after last item

Steps to reproduce

Just adding any normal action sheet is adding extra space after last item.

Is the bug present in both iOS and Android or in any one of them?

Android

[SupriyaKalghatgi]

Checked with NativeBase 2.12.0, no issues

[venkatmithun]

@SupriyaKalghatgi Please repeat the same case not different one. As you can see there is no title.

[SupriyaKalghatgi]

@venkatmithunk You dd'nt mention code snippet in issue description (as per issue template)

[venkatmithun]

@SupriyaKalghatgi

 ActionSheet.show (
      {
        options: [
          {
            text: 'Attach Photo',
            icon: 'ios-folder-open-outline',
          },
          {
            text: 'Take Photo',
            icon: 'ios-camera-outline',
          },
        ],
      },
      buttonIndex => {
        if (buttonIndex === 0) {
          this.pickImage ();
        } else if (buttonIndex === 1) {
          this.openCamera ();
        }
      }
    );

[chrfreitas-zz]

Same problem here. I'm using [email protected]

ActionSheet.show({
            options: [
              {
                text: 'Editar',
                icon: 'create',
                action: () => {},
              },
              {
                text: 'Excluir',
                icon: 'md-trash',
                action: () => deleteAction(transaction),
              },
            ],
          })

But just with more then 2 itens.

[venkatmithun]

@SupriyaKalghatgi Please reopen the issue. please test for two, three, four , five items in action sheet and you will understand.

[venkatmithun]

@SupriyaKalghatgi Any update on this?

[maulikgushani]

Any updates ?

[shubham1164]

I am also facing the same issue in native-base 2.12.0

[TxusBlack]

Same issue

[venkatmithun]

@SupriyaKalghatgi any updates on this?

[TxusBlack]

Unfortunately not, the issue is still present 🙁

[shubham1164]

@SupriyaKalghatgi any updates on this?

[TomMahle]

I've made a pr that resolves this issue in my app. Testers would be appreciated :D

[navata]

I have same issue in version 2.12.1 but I working normal in version 2.6.1.
This issue very long time. I think we should fix and resolve it.

[TxusBlack]

I've made a pr that resolves this issue in my app. Testers would be appreciated :D

Can you share it?

[TomMahle]

@TxusBlack I referenced this issue in the PR, so it's linked above, but sure: https://github.com/GeekyAnts/NativeBase/pull/2730

[navata]

@TomMahle you change this code from height:this.state.items.length*80 to height: "auto" (or your height) in 3 files as picture. Current, I fixed this issue with this solution.

[TxusBlack]

@TomMahle you change this code from height:this.state.items.length*80 to height: "auto" (or your height) in 3 files as picture. Current, I fixed this issue with this solution.

Wow! I'll try! 😄

[emision]

I'll make a PR