Nativebase: Actionsheet and Picker are bad (Android)

Created on 20 Oct 2017  路  10Comments  路  Source: GeekyAnts/NativeBase

Actionsheet:

  • largely unconfigurable and unstylable
  • works 90% of the time, every time. https://github.com/GeekyAnts/NativeBase/issues/937 was never fixed properly which leads to random crashes.
  • It just doesn't look or feel right on Android. I have not seen this type of pattern in any Google nor other apps.

Picker:

  • does anyone here think that it's okay to have all that real state, but only make the tiny dropdown clickable?
enhancement

Most helpful comment

I can make this use, the native bottom sheet, should I do that?
@akhil-geekyants

All 10 comments

The bottom sheet should slide up instead of fading in. https://material.io/guidelines/components/bottom-sheets.html

@AbdallaMohamed considering this. Will be implemented in the near future.

@akhil-geekyants I can work on this enhancement.

@jobala once completed, you can make a PR. Let us know if you need any help.

I can make this use, the native bottom sheet, should I do that?
@akhil-geekyants

Fixed with 2.5.0

  • Issue #937 is fixed with native-base version 2.5.0.

  • Implementation of ActionSheet on android is an implementation of the following screen

screen shot 2018-06-12 at 6 35 02 pm

  • NativeBase Picker for Android is a direct implementation of React Native Picker.

    Let us know if you would like us to add anything.

This issue will be closed this week in case of no response

Fixed with 2.5.0

Let me know how make actionsheet with slide animation, Can you give some example code ?

I am on version 2.13.0.. Looks like its still fading in instead of slide up... Here is how I open action sheet
ActionSheet.show()

Was this page helpful?
0 / 5 - 0 ratings

Related issues

omerdn1 picture omerdn1  路  3Comments

Bundas picture Bundas  路  3Comments

aloifolia picture aloifolia  路  3Comments

Cotel picture Cotel  路  3Comments

georgemickael-b picture georgemickael-b  路  3Comments