Nano-node: Track down potential memory leak with rai::vote
A possible memory leak has been observed. When bootstrapping a node on the live network, the vote uniquer votes container exceeds 1M entries, which is a bit unusual.
bug
rkeene
>All comments
Tracked this down to an issue with the vote uniquer.
The vote uniquer was calls votes.find(randomHash) which pretty much always returns votes.end(), which it rewrites to votes.begin() and thus would only ever delete references when votes.begin() was free-able.
rkeene
on 17 Dec 2018
👍2
Was this page helpful?
0 / 5 - 0 ratings
Related issues
termhn
路
27Comments
triwebb1
路
21Comments
rkeene
路
71Comments
SergiySW
路
23Comments
kilkelly
路
14Comments
Most helpful comment
Tracked this down to an issue with the vote uniquer.
The vote uniquer was calls
votes.find(randomHash)which pretty much always returnsvotes.end(), which it rewrites tovotes.begin()and thus would only ever delete references whenvotes.begin()was free-able.