Name-suggestion-index: Add Carino's Italian

Created on 11 Oct 2020  路  13Comments  路  Source: osmlab/name-suggestion-index

add brand good first issue question

All 13 comments

@Adamant36 Can u explain it a little ?
what do we have to do and on which page?
(link it pls)

Hello. There's a guide on how to do it in the contributing file. It probably explains things better then I could. Unless you have a specific question.

https://github.com/osmlab/name-suggestion-index/blob/main/CONTRIBUTING.md

I understand now.
Can I take this?

Yeah, sure.

Closed in #4467

@Adamant36
Ik this got closed but I thought this one's amenity is restaurant and I was going to add the code there.

Unfortunately someone else did it in the meantime. Generally, we don't assign people things and it's kind of on a "first come first serve" basis. I'm going to open some issues in a while though. So, you can work one of them if you want or another issue that's open.

I understand , I wanted to know wasn't this supposed to add to restaurant amenity?

I wanted to know wasn't this supposed to add to restaurant amenity?

Oh, I guess it was. If you want to delete the current entry and do a PR with it in the restaurant file that would be fine.

Thanks .

I've lost track of this one, but isn't "__Carino's__" just a rebrand of Johnny Carino's or are they not the same??

@UKChris-osm yup I searched and you are right!!
They are same.
Its already there in the code , same brand wikidata too.
what should I do now?
A newbie here , ur help will be appreciated.
Should I remove the pull request ?

Thanks all, I think this is good now.. It looks like they are calling themselves "Johnny Carino's" now, and we have matchNames for the older names.

      "displayName": "Johnny Carino's",
      "id": "johnnycarinos-96af40",
      "locationSet": {"include": ["us"]},
      "matchNames": [
        "carinios",
        "carinos italian"
      ],
      "tags": {
        "amenity": "restaurant",
        "brand": "Johnny Carino's",
        "brand:wikidata": "Q5039637",
        "brand:wikipedia": "en:Carino's Italian",
        "cuisine": "italian",
        "name": "Johnny Carino's"
      }
    },
Was this page helpful?
0 / 5 - 0 ratings