Nacos: "serviceId" is sensitive, may change it insensitive?

[MicyToy]

Issue Description

Type: bug report or feature request

Describe what happened (or what feature you want)

I notice that, nacos's "serviceId" is sensitive, but eureka is insensitive.
May insensitive could be better?

Describe what you expected to happen

How to reproduce it (as minimally and precisely as possible)

1. 
   
   
   2.
   
3.

Tell us your environment

nacos 0.8.0
openfeign 2.0.3-RELEASE
spring-cloud-alibaba 0.2.1-RELEASE

Anything else we need to know?

[nacos-bot]

Hi @MicyToy, we detect non-English characters in the issue. This comment is an auto translation from @nacos-bot to help other users to understand this issue.
We encourage you to describe your issue in English which is more friendly to other users.

"serviceId" is sensitive, may change it insensitive?

Issue Description

Type: bug report or feature request

Describe what happened (or what feature you want)

I notice that, nacos's "serviceId" is sensitive, but eureka is insensitive.
May insensitive could be better?

Describe what you expected to happen

How to reproduce it (as minimally and precisely as possible)

1. 
   
   
   2.
   
3.

Tell us your environment

nacos 0.8.0
openfeign 2.0.3-RELEASE
spring-cloud-alibaba 0.2.1-RELEASE

Anything else we need to know?

[nkorange]

It's a good suggestion, can you implement this feature?

[MicyToy]

Sorry, recently I have too much work to do ☹. I’m afraid I have no time to do this. Hope others can do this 😊.

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

---

From: Fury Zhu [e-mail]
Sent: Monday, March 11, 2019 10:14:01 PM
To: alibaba/nacos
Cc: MicyToy; Mention
Subject: Re: [alibaba/nacos] "serviceId" is sensitive, may change it insensitive? (#883)

It's a good suggestion, can you implement this feature?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/alibaba/nacos/issues/883#issuecomment-471554972, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ASS9n5AsYfO4d7YzlQhGsMDdYj6VtNFyks5vVmSpgaJpZM4boZFM.

[fangjianmin]

@i will solve it@

[jifengnan]

@fangjianmin 兄弟，改的咋样了，崩溃没。

[fangjianmin]

so sorry.
these times i have a lot of work to do.

[jifengnan]

@fangjianmin 别紧张，我不是催债的。我比你更早看到这个issue，也在改，只是这个东西看起来小，牵扯的地方相当多，非常头疼。

[MicyToy]

Thank you for your work, @[e-mail] , and also @fangjianminhttps://github.com/fangjianmin. :p

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

---

From: jifengnan [e-mail]
Sent: Sunday, March 24, 2019 10:00:21 PM
To: alibaba/nacos
Cc: MicyToy; Mention
Subject: Re: [alibaba/nacos] "serviceId" is sensitive, may change it insensitive? (#883)

@fangjianminhttps://github.com/fangjianmin 别紧张，我不是催债的。我比你更早看到这个issue，也在改，只是这个东西看起来小，牵扯的地方相当多，非常头疼。

―
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/alibaba/nacos/issues/883#issuecomment-475962296, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ASS9nxuvqllE8GUZE6N_LSiEhyuYgXZTks5vZ4T1gaJpZM4boZFM.

[fangjianmin]

After I read the related source code, I want to update the class
"com.alibaba.nacos.naming.core.ServiceManager".
Add "serviceName=StringUtils.upperCase(serviceName);" to where the “serviceName" occurs.
Is it Ok?

[nkorange]

@fangjianmin Make a PR and we can discuss there.

[YimRay]

well done