Hi 馃憢
The recent tag move for latest -> 8 started failing our kubernetes liveness probes:
Liveness: exec [mysqladmin ping --host 127.0.0.1 --port 3306] delay=5s timeout=5s period=10s #success=1 #failure=3
The mysql docs suggest that this tool should be usable with both MySQL 5.7 and 8.0:
It seems there may be other tools missing from the mysql:8 image as well:
comm \
<(docker run --entrypoint sh -w /usr/bin mysql:5 -c 'ls mysql*') \
<(docker run --entrypoint sh -w /usr/bin mysql:8 -c 'ls mysql*')
mysql
mysql_config_editor
mysql_embedded
mysql_install_db
mysql_plugin
mysql_secure_installation
mysql_ssl_rsa_setup
mysql_tzinfo_to_sql
mysql_upgrade
mysqladmin
mysqlbinlog
mysqlcheck
mysqld_multi
mysqld_safe
mysqldump
mysqldumpslow
mysqlimport
mysqlpump
mysqlshow
mysqlslap
Cheers
Hi,
This is an oversight in our server-core packages, sorry. The contents of the package are listed in https://github.com/mysql/mysql-server/blob/8.0/packaging/deb-in/mysql-packagesource-server-core.install.in
We did drop some of the executables from the core package, since we don't consider them necessary for most people, but mysqladmin should be there (it's in the minimal rpm used for the upstream docker image)
@ltangvald thanks for the reference.
Will mysqladmin be added back into the debian package?
I currently don't see it in that install file unless I'm missing something implicit.
Essentially https://github.com/mysql/mysql-server/commit/625609bbb9034007f498d40d5c337e9bc3a2ae87, but to add mysqladmin? :sweat_smile:
@tianon aha! yeah 馃槄
Right. We'll definitely add the binary (though to the client-core package, not server-core) for the next release.
I'm also working on finishing up the conversion of our upstream rpm-based docker images so we can provide both here (the minimal rpm we use for that has mysqladmin, so users who do not need it to be debian-based could use that)
got same problem, waiting for new release
Please also add back mysql_config_editor. It was such an elegant way to not store any passwords in clear text.
Still waiting for mysqladmin :clock1:
@toolowner: That's my mistake, sorry. It fell through the cracks. However, there isn't really much need to use the client-core package since the only difference is that these extra binaries are missing.
I've made PR #465, which should resolve this.
Fixed by https://github.com/docker-library/mysql/pull/465. :+1:
@tianon I'm curious
will this patch auto-build tonight?
last push was 3 days ago: https://hub.docker.com/r/library/mysql/tags/
(unit test still fails)
comm \
<(docker run --entrypoint sh -w /usr/bin mysql:5 -c 'ls mysql*') \
<(docker run --entrypoint sh -w /usr/bin mysql:8 -c 'ls mysql*')
thanks very much!
when he creates a pull request https://github.com/docker-library/official-images/issues?&q=label%3Alibrary%2Fmysql
ah thanks @Coolfeather2
Most helpful comment
@toolowner: That's my mistake, sorry. It fell through the cracks. However, there isn't really much need to use the client-core package since the only difference is that these extra binaries are missing.
I've made PR #465, which should resolve this.