Mybatis-3: Interface naming is not standard

[zjcnb]

Hi，all，

Recently watching mybaits source, found an interface name is not standard, hope to adopt correct, AutomapConstructor interface, path: org/apache/ibatis/annotations/AutomapConstructor. Can you modify it to AutoMapConstructor

[harawata]

Consistency is important, however, I am not sure if this particular change is important enough to break backward compatibility...
Comments are welcome. :)

[zjcnb]

I think it's necessary because this project is for developers all over the world, and naming conventions are what we should have most. I think this change will lead to all changes in users'applications, but this change is very small. I think it's perfectly acceptable.

发自我的iPhone

------------------ Original ------------------
From: Iwao AVE! [e-mail]
Date: Sun,May 26,2019 0:04 AM
To: mybatis/mybatis-3 [e-mail]
Cc: zjcnb [e-mail], Author [e-mail]
Subject: Re: [mybatis/mybatis-3] Interface naming is not standard (#1545)

[jeffgbutler]

There are many things that we would change in MyBatis if we didn’t need to be concerned with backwards compatibility. But for now I agree with @harawata, this is a breaking change to a public interface and I don’t think it should be done like this.

If we decide it is necessary to rename an annotation, we should create a new one, deprecate the old one, and live with both for a transition period.

[kazuki43zoo]

@zjcnb 's suggestion is correct. But the my opinion is same with @jeffgbutler. I believe that keeping a backward compatibility is very important for changes of improvement(= not bug) of existing feature at maintenance version up because the MyBatis have many users.

[harawata]

I'm OK with deprecating the current annotation.
Is there any problem with having both AutomapConstructor.java and AutoMapConstructor.java?
(On Windows, I mean)

[kazuki43zoo]

On Windows,

Oh.. Windows is case in-sensitive by default. However, since "Windows 10 April 2018 Update", it can be control enabling/disabling case sensitive entry.
see https://www.tenforums.com/tutorials/111293-enable-disable-case-sensitive-attribute-folders-windows-10-a.html

[harawata]

Well, even on Mac, I cannot create AutoMapConstructor.java on Eclipse :P (it says 'Name Conflict : Resource exists with different case').
So, we need another name. How about AutoMappingConstructor?

[h3adache]

Automap (lower case m) is well understood and often used word in technical and even none technical sources. Google search for “define automap”
It is also the closest definition of what we are doing with that annotation so I disagree that it is not named correctly.

[mnesarco]

I think this change is not worth the pain. This change will add nothing
than problems.

Just my opinion.

El mié., 5 de junio de 2019 2:02 p. m., Tim Chen [e-mail]
escribió:

Automap (lower case m) is well understood and often used word in technical
and even none technical sources. Google search for “define automap”
It is also the closest definition of what we are doing with that
annotation so I disagree that it is not named correctly.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mybatis/mybatis-3/issues/1545?email_source=notifications&email_token=AAIJOVNKNYI4CYC4PRDNKATPZAEVJA5CNFSM4HN75UZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXAWKYQ#issuecomment-499213666,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIJOVK6DPWVLVLLQJEJAF3PZAEVJANCNFSM4HN75UZQ
.

[harawata]

Thank you for the input, @h3adache @mnesarco !

@zjcnb ,
As you can see, most members prefer not to change the annotation name, so I'll close this issue.
Thanks a lot for taking the time to share your opinion and submit the PR!