Mvc: WebApplicationFactory should provide a virtual Dispose() method

Created on 11 Apr 2018  路  4Comments  路  Source: aspnet/Mvc

The WebApplicationFactory<T> class in Microsoft.AspNetCore.Mvc.Testing should provide the standard protected virtual void Dispose(bool disposing) method to allow derived classes to override the method to dispose of resources they might create themselves.

1 - Ready bug

All 4 comments

Thanks for reporting this issue. We agree that this seems to be a bug and we've assigned one of our team members to look into this based on its priority.

I can do a PR to add this for 2.1.0 if wanted? Otherwise in 2.2.0 would it be a breaking change to the public contract?

Feel free to send us a pr, that would be helpful 馃憤

7637

Was this page helpful?
0 / 5 - 0 ratings

Related issues

DamianEdwards picture DamianEdwards  路  3Comments

saf-itpro picture saf-itpro  路  3Comments

kspearrin picture kspearrin  路  4Comments

workmonitored picture workmonitored  路  3Comments

miroslavsiska picture miroslavsiska  路  4Comments