Musicbot: Ignore songs which has been played recently

[VF2blaze]

I have over 100 songs in my autoplaylist but there a lot of times where it would play recent songs over and over again. It would be nice if it didn't play a song that was already played in the previous five.

[imayhaveborkedit]

I get a lot of reports that the autoplaylist seems to play the same things frequently. I don't know how or why, but i'll change how songs are picked.

[ghost]

It seems when cached, it plays the same song over very frequently.
Adding an Autoplaylist shuffle with Python's random.shuffle using the Fisher-Yates shuffle should help perhaps.

[stuntguy3000]

Any updates?

[cassidy3]

I don't have much technical knowledge with python, but it seems like a better algorithm would take the whole playlist, shuffle it, play it from start to finish, then repeat. That makes more sense to me than playing a completely random song each time since there's really no way to prevent repeats as far as I can tell. I don't know how difficult this would be to code, however.

[stuntguy3000]

@Swipefly There are features within this bot to add played songs into the autoplaylist. I will argue that preshuffling the list, whilst leading to more randomness, will exclude new songs. But, this may also be a good feature.

[cassidy3]

I don't think many people change the autoplaylist frequently, and they could always use the shuffle command to reshuffle it and add the new songs in :)

[ConnorPickles]

I've fixed this particular issue and added a pull request to review

[arcturus1259]

the fix you provided was for the review branch, and chance we can get a fix for the master branch?

[jaydenkieran]

Fixed in 1.9.6_1.