Mumble: latest release 1.3.1-rc1 fails to build

[david-geiger]

Hi,

I tried On Mageia Cauldron to build latest 1.3.1-rc1 release but it fails to build from source due to missing headers:

-I../../src -I. -I../mumble_proto -I../../3rdparty/arc4random-src -Imurmur_ice -Imurmur_grpc -I../../3rdparty/qqbonjour-src -isystem /usr/include/avahi-compat-libdns_sd -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtNetwork -isystem /usr/include/qt5/QtSql -isystem /usr/include/qt5/QtXml -isystem /usr/include/qt5/QtDBus -isystem /usr/include/qt5/QtCore -I../../release/.moc/murmur -I/usr/lib64/qt5/mkspecs/linux-g++ -o ../../release/.obj/murmur/MurmurGRPCImpl.o MurmurGRPCImpl.cpp
MurmurGRPCImpl.cpp:21:10: fatal error: Utils.h: No such file or directory
21 | #include "Utils.h"
| ^~~~~
compilation terminated.

build.0.20200413083309.log

Regards,
David

[davidebeatrici]

Hi,

Is src/Utils.h present?

[Krzmbrzl]

Were you able to build successfully with GRPC enabled for the 1.3.0 branch?

[david-geiger]

Nop src/Utils.h is not present.

And 1.3.0 release build sucessfully:

build.0.20200319152711.log

[davidebeatrici]

Thank you for reporting the issue, 58d27c68a9d131e111ca488b42469bdae68e06e2 should be backported.

[Krzmbrzl]

@davidebeatrici will you do the backport? Do we want to backport #3644 as a whole or only that single commit?

[davidebeatrici]

Single commit, feel free to do it.

[david-geiger]

Now another build issue:

../Group.cpp:6:10: fatal error: murmur_pch.h: No such file or directory
#include "murmur_pch.h"
^~~~~~
compilation terminated.

I think that this commit will also be needed: https://github.com/mumble-voip/mumble/commit/5a07244a449592a143a628fde9b84846ee82e0

mumble_build_log.txt

[david-geiger]

So now after PR https://github.com/mumble-voip/mumble/pull/4068/commits/d68beacfd9d65fe012b9a90eeeb6fe4027343cda again a build issue:

AudioConfigDialog.cpp: In member function 'virtual void AudioInputDialog::load(const Settings&)':
AudioConfigDialog.cpp:120:28: error: 'iroundf' was not declared in this scope

Seems now this commit https://github.com/mumble-voip/mumble/commit/15831dbca85dd906edbad2bfff2b147527a456e2 is needed.

[david-geiger]

So ok now it build fine with PR https://github.com/mumble-voip/mumble/pull/4068

[Krzmbrzl]

Huh? how can that be? I've rolled back to backporting only that first commit as the other commits introduced loads of problems with Qt4 xD
(I'll add some fixes for it though. Just didn't get to it yet)
Have you built with Qt5 and from an older version (aka 12 hours ago or so) of that PR?

[david-geiger]

Yes I've compiled with Qt5 and with the PR from yersterday.

[Krzmbrzl]

Ah okay that explains it ^^
I'm at fixing up the PR right now. Would appreciate if you could find the time to verify it to be working afterwards (I'll probably push the fixes within the next hour or so) :)

[david-geiger]

Yes I can no problem, but which commit/PR should I use exactly?

[Krzmbrzl]

4068 there's only a single commit in it, but it's not the same that was in it yesterday ^^

[david-geiger]

Here it built fine with this single commit against Qt5.

[Krzmbrzl]

Perfect, thanks :)

[Krzmbrzl]

Fixed by #4068

[theAkito]

@Krzmbrzl

Trying to build tag 1.3.1-rc1 results in:

MurmurGRPCImpl.cpp:21:10: fatal error: Utils.h: No such file or directory
   21 | #include "Utils.h"
      |          ^~~~~~~~~
compilation terminated.
make[2]: *** [Makefile.Release:1139: ../../release/.obj/murmur/MurmurGRPCImpl.o] Error 1
make[2]: Leaving directory '/root/mumble/src/murmur'
make[1]: *** [Makefile:42: release] Error 2
make[1]: Leaving directory '/root/mumble/src/murmur'
make: *** [Makefile:460: sub-src-murmur-release_ordered] Error 2

---

Apparently, the tag is not up to date. For these backports to take effect, one has to compile on branch 1.3.x.

[Krzmbrzl]

Yeah I think that's just how GitHub tags work...

From your comment I take it that the build works with the 1.3.x branch for you, right?

[theAkito]

@Krzmbrzl
At the time of commenting, I had not tried it, yet.

However, now I can confirm the 1.3.x branch indeed works, as it contains all the backported commits, too. (There were some deprecation warnings, but no fatal/aborting errors.)

As for the tags, one would need to delete the respective local and remote tag, then re-push the newly created tag that contains all the new backported commits.

[Krzmbrzl]

Yeah we should release 1.3.1 soon anyways. Thus I don't think it to be that bad if the 1.3.1.rc1 has some issues...