Mtasa-blue: Blip size is not checked the same way as on server-side

Created on 29 Jul 2018  路  3Comments  路  Source: multitheftauto/mtasa-blue

Describe the bug
You can create a blip with size over 25, which is what the limit is server-side. Code is inconsistent.

To reproduce

  • createBlip( 0, 0, 3, 0, 500 ) -> works
  • createBlipAttachedTo( localPlayer, 0, 500 ) -> works
  • setBlipSize( blip, 500 ) -> works

Expected behavior
Clamped between 0 and 25.

Screenshots
mta-screen_2018-07-29_20-05-55

MTA Client & Server:

  • Multi Theft Auto v1.5.5-release-13816
  • Windows 10.0.17134.165

Additional context

  • Discovered by zHooP on Discord. Thanks.
  • This bug has been in the client code forever.
  • Better to make it backwards compatible and clamp the size instead of returning false upon invalid size.
bug

All 3 comments

What do you think about also throwing a warning if the size exceeds the limits?

That sounds like a fair enough addition, but that should be added only client-side, as that is the only part affected.

fixed in #279

p.s. @patrikjuvonen

Was this page helpful?
0 / 5 - 0 ratings

Related issues

CrosRoad95 picture CrosRoad95  路  4Comments

qaisjp picture qaisjp  路  4Comments

patrikjuvonen picture patrikjuvonen  路  3Comments

umitemre picture umitemre  路  4Comments

LosFaul picture LosFaul  路  4Comments