Msys2-packages: fish broken

[Optiligence]

It’s missing a dependency of libpcre2_16 but also doesn’t start after that’s installed.

[orthoxerox]

See https://github.com/fish-shell/fish-shell/issues/5426

[Alexpux]

@orthoxerox use always __CYGWIN__ GCC internal defines to distingish Cygwin/MSYS. Don't define your own CYGWIN from cmake

[orthoxerox]

@Alexpux that's something @mqudsi should take a look at, but I see you've already commented on their PR. I guess this is an extra one line patch for the MSYS2 package when 3.0.1 comes around if they don't fix it upstream.

[mqudsi]

Thanks for that info, I'll look into updating it. Regardless of CYGWIN or __CYGWIN__, the fish package maintainers are recommended to move over to cmake as we will be removing support for the autotools build system.

[Turbid]

I confirm this:
C:/msys64/usr/bin/fish.exe: error while loading shared libraries: msys-pcre2-16-0.dll: cannot open shared object file: No such file or directory

After installing libpcre2_16 it does not work.

[Optiligence]

my 2 cents: Since the older version still works, I would like the update to be revoked/push to pacman repo with old version – in cases like this.
It prevents broken updates for users that haven’t updated yet and allows easy downgrade via pacman -Syuu for those who already have.
@Alexpux

[PetarKirov]

I worked around the problems with this commit: https://github.com/ZombineDev/MSYS2-packages/commit/7acd480f8c0deec3b5e3c241ca6bf568a85f9a18. It's not of upstream quality, and so I don't intend to open a pull request, but it should be good enough for everyone who want to try fish under msys2.

[wildtang]

I worked around the problems with this commit: ZombineDev@7acd480. It's not of upstream quality, and so I don't intend to open a pull request, but it should be good enough for everyone who want to try fish under msys2.

Hi, I test this commit with the commands below:

$ git clone https://github.com/Alexpux/MSYS2-packages

$ pacman -S binutils patch gcc gettext-devel intltool libiconv-devel ncurses-devel pcre-devel doxygen pcre2-devel

$ cd ./MSYS2-packages/fish

$ makepkg --skippgpcheck

$ pacman -U ./fish-3.0.0-2-x86_64.pkg.tar.xz

It looks like still not works, fish still cannot be startup.

[mqudsi]

You need to use the code from fish master or the fish 3.0.1 branch.

[wildtang]

You need to use the code from fish master or the fish 3.0.1 branch.

Yes, I made a mistake.

Use the commands below, I have built out a runnable fish 3, Thanks you! and Thanks https://github.com/ZombineDev

$ git clone https://github.com/ZombineDev/MSYS2-packages.git
$ cd ./MSYS2-packages/fish
$ git checkout workaround-fish
$ makepkg --skippgpcheck

[nyfair]

I confirm that 3.0.1 already fix this issue