Msbuild: RoslynCodeTaskFactory assembly cache doesn't work

Created on 9 Dec 2020  路  3Comments  路  Source: dotnet/msbuild

RoslynCodeTaskFactory compiles a new assembly every time it is called. Check out the cache:

image

Tasks macOS Performance-Scenario-Build bug performance untriaged
Source
picture KirillOsenkov

Most helpful comment

Also return 0 for GetHashCode() probably doesn't help either.

picture KirillOsenkov on 9 Dec 2020
😄3 👀2

All 3 comments

This line probably returns false when comparing two hashsets:
https://github.com/dotnet/msbuild/blob/1ff34e830630ff7c4b6cb008e85ece4f263ace52/src/Tasks/RoslynCodeTaskFactory/RoslynCodeTaskFactoryTaskInfo.cs#L54

KirillOsenkov picture KirillOsenkov on 9 Dec 2020

Also return 0 for GetHashCode() probably doesn't help either.

KirillOsenkov picture KirillOsenkov on 9 Dec 2020
😄3 👀2

Here's what I think a fix could be:
https://github.com/mrward/msbuild/pull/1

KirillOsenkov picture KirillOsenkov on 9 Dec 2020
Was this page helpful?
0 / 5 - 0 ratings

Related issues

ctolkien picture ctolkien  路  4Comments
cdmihai picture cdmihai  路  4Comments
hawkerm picture hawkerm  路  4Comments
Chopping picture Chopping  路  4Comments
ackh picture ackh  路  3Comments