Mremoteng: 'Switch to notification panel' feature does not always switch

[sparerd]

The Switch to Notifications panel on feature in Options -> Notifications does not always switch to the notifications panel when messages are received.

Expected Behavior

Current Behavior

Steps to Reproduce (for bugs)

1. Ensure all Tools -> Options -> Notifications -> Switch to Notifications panel on check boxes are checked.
2. Perform actions around the app (start a connection, save the connections file, etc)
3. The first several messages seem to switch focus to the notification window, but after that it stops working. Threading/ordering issue?

Context

Your Environment

• Version used: 1.76.4 (develop branch 00b7b12)

[sparerd]

It seems that disconnecting a connection consistently causes the message focusing to stop working.

I've tried adding some lock statements in MessageFocusDecorator.cs but that only fixes a few cases. Somehow the timer we are using gets stuck in the 'on' state but does not raise any events.

[sparerd]

It was definitely a threading thing, but I'm still not sure exactly what was going on. I replaced the complicated implementation using Timer with a simple Task async call. Works like a charm.

There is one caveat though - I still can't get the notifications form to be shown when its panel is set to auto hide. The new message will be highlighted correctly, but the auto-hidden form doesn't pop up/out like it should when a message is received. I suspect this is just some DockPanelSuite thing that I'm not doing correctly.

This line should show the notification panel (and it does for non-auto hidden forms).
https://github.com/mRemoteNG/mRemoteNG/blob/release/v1.76/mRemoteV1/Messages/WriterDecorators/MessageFocusDecorator.cs#L75

@kmscode You may know DPS better - any ideas?