Apple maintains a list of Swift projects and their Swift version compatibilities here, which is used as a test suite to guard against regressions in the Swift language. Now that Moya supports Swift 4, we should add that compatibility to our specification:
Instructions are in the readme. Once added, the ./project_precommit_check script can be run to verify everything works, and a pull request can be submitted to Apple's repo.
This should be a straightforward task and an ideal one for anyone who wants to get more involved in the Swift community.
ashfurrow
All 4 comments
kimdv
on 27 Feb 2018
Nice work!
ashfurrow
on 27 Feb 2018
It seems that the build failed
https://ci.swift.org/view/Source%20Compatibility/job/swift-master-source-compat-suite/1339/console
But what I can read, it is Moya passes, right?
kimdv
on 1 Mar 2018
Yep, it's all good @kimdv. Thank you for taking care of this issue so Swiftly 馃槅 鉂わ笍
SD10
on 1 Mar 2018
Related issues
cocoatoucher
路
3Comments
syq7970
路
3Comments
PlutusCat
路
3Comments
hjzCy
路
3Comments
Tynox
路
3Comments
Most helpful comment
https://github.com/apple/swift-source-compat-suite/pull/148