Moya: Update ReactiveSwift dependency to 2.0

Created on 22 Jul 2017  ·  7Comments  ·  Source: Moya/Moya

Hello Community, I just making request for update ReactiveSwift dependency to 2.0.

enhancement

Most helpful comment

Hey @larryonoff! Your proposal is just in time for our 9.0.0 version 😄 I think this one can get in as well, what do you guys think, @Moya/contributors?

All 7 comments

Hey @larryonoff! Your proposal is just in time for our 9.0.0 version 😄 I think this one can get in as well, what do you guys think, @Moya/contributors?

Sounds good to me!
On Sat, Jul 22, 2017 at 3:35 AM Łukasz Mróz notifications@github.com
wrote:

Hey @larryonoff https://github.com/larryonoff! Your proposal is just in
time for our 9.0.0 version 😄 I think this one can get in as well, what
do you guys think, @Moya/contributors
https://github.com/orgs/Moya/teams/contributors?


You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Moya/Moya/issues/1182#issuecomment-317174538, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADo1dFjjCxZclQaRMAkGpxoyNoOk9ZR4ks5sQdB3gaJpZM4OgHcz
.

Cool! I think we should do it after #1181 merges onto master since there are many changes already.

Also, maybe you would be up for doing PR with the update, @larryonoff? 😉

@sunshinejr I wanted to do PR. I'm sure that it should be very easy PR. But I didn't find quickly how to configure the project dependencies for contributing. Could anyone please assist? Is it just one Carthage command?

@larryonoff carthage bootstrap

@SD10 thank you!

created PR #1185

Was this page helpful?
0 / 5 - 0 ratings