Moya: RxSwift dependency not compatible with Xcode 9 and Swift 3.2

[LeonardoCardoso]

Moya Version: 8.0.5

The current version of RxSwift dependency is not compatible with Xcode 9 and Swift 3.2. Thus, projects can't be compiled.

ss.dependency "RxSwift", "~> 3.0"

I've solved this just by changing the dependency version. I can create a PR if it's needed.

ss.dependency "RxSwift", "~> 3.5"

[BasThomas]

Thanks for noticing, @LeonardoCardoso! @Moya/contributors, should we release 8.0.6 to support this for version 8 still, or do we want to hold off on this for v9? Not sure if this would break anything?

[devxoul]

How about >= 3.0?

[pedrovereza]

@devxoul By using ~> 3.0 we are saying we can take anything from 3.0 up until 3.9. The problem here is that our minimal version should be 3.5 now.

We would still want to use ~> 3.5, as >= 3.0 means we could take, for example, version 4.0, which would include breaking changes that we may not be ready to take.

[BasThomas]

This confuses me every time. Why does 3.5 not work at this point, then? 3.5 is in the range of 3.0 and 4.0, so that should work? 🤔

[BasThomas]

@LeonardoCardoso, I just set up a test project and it seems to work fine with RxSwift. Alamofire seems not to be updated yet, though, and causes an error.

Have you tried pod update? A fresh install uses RxSwift 3.5.

[BasThomas]

$ pod install
Analyzing dependencies
Downloading dependencies
Installing Alamofire (4.4.0)
Installing Moya (8.0.5)
Installing Result (3.2.3)
Installing RxSwift (3.5.0)
Generating Pods project
Integrating client project

[pedrovereza]

@BasThomas @LeonardoCardoso Yea, just double checked that I have a dummy project that is using RxSwift 3.5 as well.

@LeonardoCardoso If pod update doesn't solve it for you, could you share the content of your Podfile and Podfile.lock?

[LeonardoCardoso]

That's weird. So this is my scenario: I have both Xcode and Xcode-beta on my Mac. After updating Xcode to 8.3.3, it failed to work, but after a pod update it worked. Sorry for this false positive and thanks for the fast response. I'm closing the issue.