MoyaAvailability.swift marks Moya.Error as unavaliable, but also tries to use Moya.Error in the same file

[aufflick]

As of Jan 4 commit, MoyaAvailability.swift marks Moya.Error as unavaliable, but also tries to use Moya.Error in the same file:

@available(*, unavailable, renamed: "MoyaError", message: "Moya.Error has been renamed to MoyaError in version 8.0.0")
public typealias Error = MoyaError

...
    func didReceiveResponse(result: Result<Moya.Response, Moya.Error>, target: TargetType) { fatalError() }

Generates a compiler error.

[aufflick]

Ah - it's only a compiler error in Swift 3.1. Swift 3.0 seems to only apply the @unavailable outside the file.

[scottrhoyt]

Thanks for bringing that up though! We should put that on our radar for Swift 3.1 release @Moya/contributors.

[hartbit]

Since Swift 3.1 is supposed to be backwards compatible with Swift 3.0, I think the Swift dev team will be interested by this: @DougGregor @jckarter

[BasThomas]

This is true indeed; Swift 3.1 should be source compatible with 3.0.

[jckarter]

This sounds like a bug fix to me, but I'll raise it with the core team.

[jckarter]

There was a fix that attempted to emulate the 3.0 behavior and emit warnings in this case:

https://github.com/apple/swift/commit/9489f10ce1feb60e9fb0a32857a273a22420253b

It's recent enough that it may not have made it into 8.3 beta 1. Do you still see the error in 8.3 beta 2, or in a Swift 3.1 snapshot toolchain from swift.org?

[DougGregor]

The Swift 3.0 compatibility fix @jckarter referred to was first introduced in Xcode 8.3 beta 2.

[hartbit]

@DougGregor This is still happening on Xcode 8.3 Beta 2 and with the latest 3.1 Toolchain (2017-02-07).

[ened]

Should this meanwhile be fixed in Moya (and renamed to MoyaError)?

[scottrhoyt]

@ened as long as we can verify that doing so still offers the fix-its when trying to use the renamed methods, I think that is reasonable.

[jckarter]

The availability fixits should still appear. Let us know if they don't. The only change should have been to tighten up the checking of availability on typealiases.

[scottrhoyt]

Thanks everyone. PR inbound.

[sandeepbol]

I am trying to convert my Project from Swift 2.3 to Swift 3 in Xcode 8.3 beta 2. What should be done here to fix this issue. If I try to rename Error to MoyaError, Xcode cribs that I file is locked to changes. Still new to Swift and this migration is getting little painful. Any help is appreciated.

Thanks.

[BasThomas]

This fix has not been included in a release yet, right @scottrhoyt?