Moviepy: It’s time for a new release

[tburrows13]

The last release of moviepy was version 0.2.3.2, on 13 April 2017. There have been 125 commits to master since then. It’s definitely time for a new release.

I don’t know how to do a release, so if someone could let me know how moviepy does it, that would be fantastic! @mbeacom did all of the most recent ones.

To do:

• [x] Merge any last PRs (the only one I can particularly see needs doing is #731)
• [x] Create a release on releases page. From what I can tell, the “Merged pull requests” and “Closed issues” sections are automatically generated. If they are, how is it done?
• [x] Build and push to PyPI
• [ ] Build the docs, and make the changes live

Is there anything else I’ve forgotten?

[Zulko]

Hey - Thanks for this. For #731 I think that's a good PR (any other opinion). For the release features i can have a look and do it when you give me a green light. Same for pypi push and docs.

[tburrows13]

Thank you! I’ll take a look at your suggestion for #731, that’s really helpful, and something I hadn’t considered.

I would quite like to learn how the PyPI push and building the docs works, would you mind showng how it’s done? Thank you very much!

[tburrows13]

I really think this needs to be top priority now. I’ve merged all outstanding PRs, and as soon as I can I’ll build a changelog for the release page. I think I’ll also add a CHANGLOG.md file.

When I’ve done that I’ll let @Zulko know and we can work on pushing it to PyPI and rebuilding the docs. Just note that PyPI is currently undergoing a revamp, so that _may_ complicate things slightly.

Then, for the next release, my top priorities are sorting out the unclosed processes (with a clip.close() method), adding the ability to reroute the progress bar to a custom function, and supporting Windows better (currently the tests don’t complete properly). There are currently PRs for all these, but I’d like to properly review and research them.

[tburrows13]

@Zulko I've created a changelog here for version 0.2.3.3. If you could do whatever needs to be done to update the documentation and PyPI listing that would be fabulous! Even better if you can document what gets done on the wiki page. Thanks

[Zulko]

This is awesome. I'll get started on the release about 1h. In the mean time can you create an account for you on PyPI so I can give you access for the next releases ?

[tburrows13]

Thank you for your prompt response! My PyPI profile is now here.

[Zulko]

Done. But I had to do 2 changes (in particular, changing the version to 0.2.3.3 in version.py), so the code in the repo is not exactly the same as the one in the Github release.

I have added you as a maintainer on PyPI. You can now do uploads yourself. Uploading a new version is as simple as (1) bumping up the version number in version.py, (2) running python setup.py sdist upload. The subtle thing is PyPI authentication, for which you need a .pypirc file in your HOME folder, with the following content:

[distutils]
index-servers =
    pypi

[pypi]
repository:https://pypi.python.org/pypi
username:myUsrName
password:MypasSwooord

I'll do the documentation update tomorrow.

[mgaitan]

hey guys, congrats on the new release!

just a comment: why 0.2.3.3 ? I feel that the "increment" in the version number underrepresent the importance of the release. In my opinion, the project should be stick to the semantic versioning policy as far as possible, https://semver.org/. In that scheme, 3 numbers are enough, (major.minor.patch) and this release should be considered a minor.

just my two cents.

PS: thanks for this amazing software. I hope to contribute more often.

[tburrows13]

Thanks for pointing that out again @mgaitan. I thought it would be better to start at 1.0 with the next update, which should hopefully have a couple of new features. I was considering incrementing this update to 0.2.4, but actually, there’s really no new features, just a lot of bug fixes and internal changes (docs, tests etc). So I didn’t quite feel that it was appropriate. We’ll definitely get it right next time :)

[Zulko]

The number of changes would have justified 0.2.4 or even 0.3 I think but I'm not a versionning expert. Let's keep 1.0 for when MoviePy is as full-featured as Adobe Premiere Pro, which was the original intent :stuck_out_tongue:

Despite the multiplication of maintainers in the past year there still seems to be times when everyone is busy, so maybe you could get maintainer access to the repo @mgaitan if you want to ? (@mbeacom @kerstin @tburrows13 @earney what do you think ?)

[tburrows13]

@Zulko does it give you the option to delete releases from the release page? It doesn’t for me but o think it should.

[Zulko]

I just deleted the latest release (you need to go to releases, then click on the release title, then in the top-right you should have edit/delete, let me know if you have this)

[mgaitan]

@Zulko I'd be very glad to be a maintainer, thanks! Moreover, I consider that the Wiki could be public (for instance, to have a page of "projects using moviepy" or even "recipes", and I could help not only to write there but to moderate content if needed.

[tburrows13]

@Zulko no it doesn't let me delete releases, apparently only the owner can do that. I'm all for adding @mgaitan as a collaborator.

Only the owner can edit the wiki settings to make it public. I'm not sure we want to do that, but we could put something somewhere to say create a PR (like #509) to extend the docs page here. We could certainly make this more user-friendly. I don't have strong opinions either way though.

[tburrows13]

Ok, I've fixed the release here. I deleted the tag, and recreated the release.